Message validation estimated round checks - #1253
Closed
nkryuchkov wants to merge 22 commits into
Closed
Conversation
nkryuchkov
commented
Dec 26, 2023
nkryuchkov
commented
Contributor
- Rewrite estimated round calculation logic according to changes in Deterministic Round Timeout #1120
- Enable lowest allowed round check
nkryuchkov
marked this pull request as ready for review
December 29, 2023 08:58
This reverts commit 990daa6.
y0sher
reviewed
Jan 7, 2024
y0sher
reviewed
Jan 7, 2024
y0sher
reviewed
Jan 7, 2024
This reverts commit 0aca829.
y0sher
requested changes
Jan 7, 2024
y0sher
left a comment
y0sher
left a comment
Contributor
There was a problem hiding this comment.
small changes, lets put some effort into testing this. @nkryuchkov
Contributor
Author
|
I tested this PR and while performance looked good, I saw significant amount of messages violating estimated round rules. Their timestamp looked like the rule was applied correctly, but the reason for the odd timestamp is unknown. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.