gas-limit: default to 36 - #2307
Conversation
Codecov ReportAttention: Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f7d3176 to
ec14f6b
Compare
y0sher
left a comment
There was a problem hiding this comment.
Honestly I don't like that most changes here are not directly related to the task.
Yeah, most of the changes are the result of me trying to make sense of how validator-options are supposed to work (so I can initialize GasLimit36-related one properly). It doesn't have to be all in a single PR, @y0sher can we merge the related preliminary refactoring(clean-up) PR - #2308 such that GasLimit36-related diff would look more like this ? This refactoring isn't strictly necessary to merge before this change, but I think it makes sense to to it in this order (rather than trying to fit GasLimit36-related diff with the current code version) |
ec14f6b to
b9e69fd
Compare
b9e69fd to
5ff10e9
Compare
…repo) so we don't depend on them
* gas-limit: default to 36 * some adjustments (+ addressing review comments) * regenerate mocks, fix compilation issues * fix unit-tests * fix spec-tests * fix spec-tests * define default gas-limit constants in this repo (instead of ssv-spec repo) so we don't depend on them * go mod tidy * make sure we don't accidentally ship gas-limit-36 update without intended epoch set * use old constant for spec-tests to pass
Depends on:
ssv-speclib version later on due to gas-limit: default to 36 #2307 (comment) and leave a TODO for it in this PR instead)GetGasLimit36Epochto be a pointer-receiverBefore merging:
GetGasLimit36Epochto be a pointer-receiver (once netowkrconfig: use pointer receivers (to avoid lots of copies) #2304 is merged)