Skip to content

gas-limit: default to 36 - #2307

Merged
y0sher merged 10 commits into
stagefrom
gas-limit-default-to-36
Jun 25, 2025
Merged

gas-limit: default to 36#2307
y0sher merged 10 commits into
stagefrom
gas-limit-default-to-36

Conversation

@iurii-ssv

@iurii-ssv iurii-ssv commented Jun 19, 2025

Copy link
Copy Markdown
Contributor

Depends on:

Before merging:

@codecov

codecov Bot commented Jun 20, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.8%. Comparing base (f556934) to head (d65b26b).
Report is 4 commits behind head on stage.

Files with missing lines Patch % Lines
networkconfig/ssv.go 50.0% 2 Missing ⚠️
utils/testutils.go 0.0% 2 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iurii-ssv
iurii-ssv force-pushed the gas-limit-default-to-36 branch from f7d3176 to ec14f6b Compare June 20, 2025 17:47
Comment thread networkconfig/beacon.go Outdated
Comment thread protocol/v2/ssv/validator/opts.go Outdated

@y0sher y0sher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I don't like that most changes here are not directly related to the task.

@iurii-ssv

iurii-ssv commented Jun 23, 2025

Copy link
Copy Markdown
Contributor Author

Honestly I don't like that most changes here are not directly related to the task.

Yeah, most of the changes are the result of me trying to make sense of how validator-options are supposed to work (so I can initialize GasLimit36-related one properly). It doesn't have to be all in a single PR,

@y0sher can we merge the related preliminary refactoring(clean-up) PR - #2308 such that GasLimit36-related diff would look more like this ? This refactoring isn't strictly necessary to merge before this change, but I think it makes sense to to it in this order (rather than trying to fit GasLimit36-related diff with the current code version)

@iurii-ssv
iurii-ssv marked this pull request as draft June 23, 2025 07:42
@iurii-ssv
iurii-ssv force-pushed the gas-limit-default-to-36 branch from ec14f6b to b9e69fd Compare June 23, 2025 08:14
@iurii-ssv
iurii-ssv force-pushed the gas-limit-default-to-36 branch from b9e69fd to 5ff10e9 Compare June 23, 2025 15:16
Comment thread networkconfig/mainnet.go Outdated
@iurii-ssv
iurii-ssv marked this pull request as ready for review June 24, 2025 15:18
Comment thread protocol/v2/ssv/validator/opts.go Outdated
Comment thread networkconfig/ssv.go
@y0sher
y0sher merged commit acda0a3 into stage Jun 25, 2025
@y0sher
y0sher deleted the gas-limit-default-to-36 branch June 25, 2025 12:03
anatolie-ssv pushed a commit that referenced this pull request Jun 25, 2025
* gas-limit: default to 36

* some adjustments (+ addressing review comments)

* regenerate mocks, fix compilation issues

* fix unit-tests

* fix spec-tests

* fix spec-tests

* define default gas-limit constants in this repo (instead of ssv-spec repo) so we don't depend on them

* go mod tidy

* make sure we don't accidentally ship gas-limit-36 update without intended epoch set

* use old constant for spec-tests to pass
kchojn added a commit that referenced this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants