Stage <- Main + resolved conflicts - #2395
Merged
Merged
Conversation
…gner_endpoint Configuration (#2350) * [SSV-16,SSV-20] ssvsigner: Possible Local File Read + SSRF via Web3signer_endpoint Configuration
* [SSV-13] ssvsigner: fix remaining data races * don't obtain redundant locks
* [SSV-2] ssvsigner: error on empty fingerprints * fix a comment
…, to get the slot (#2370) * refactor(executionclient): remove BlockByNumber method from Provider interface and related implementations to streamline code test(executionclient): remove tests for BlockByNumber method to reflect its removal and maintain test accuracy fix(scheduler): update ExecutionClient interface to replace BlockByNumber with HeaderByNumber for consistency refactor(scheduler_mock.go, voluntary_exit.go, voluntary_exit_test.go): rename BlockByNumber to HeaderByNumber for consistency with the underlying method and improve clarity in the codebase * refactor(event_syncer_test.go): remove unused channels to clean up test code refactor(multi_client_test.go): change return type from Block to Header in mock client to align with expected behavior * refactor(voluntary_exit): rename variable block to header for clarity in handling block headers test(voluntary_exit_test): update variable name from blockByNumberCalls to headerByNumberCalls for consistency with refactor
* Add stale bot * Specify cron
* ssvsigner-tls-load-hostname-from-multiple-sources * cleanup * add removed comments * fix the logic * add a unit test --------- Co-authored-by: Nikita Kryuchkov <nkryuchkov10@gmail.com>
* fasttrack: gas-limit-36: enable on exact epoch configured * fix spec-alignment --------- Co-authored-by: rehs0y <lyosher@gmail.com>
# Conflicts: # eth/executionclient/multi_client_test.go # networkconfig/hoodi.go # networkconfig/mainnet.go # operator/duties/voluntary_exit.go # operator/duties/voluntary_exit_test.go # operator/validator/controller.go # protocol/v2/ssv/runner/validator_registration.go # protocol/v2/ssv/validator/opts.go # scripts/spec-alignment/differ.config.yaml
nkryuchkov
requested review from
MatusKysel,
iurii-ssv,
kchojn,
oleg-ssvlabs and
olegshmuelov
July 14, 2025 17:22
Closed
Codecov ReportAttention: Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kchojn
previously approved these changes
Jul 15, 2025
MatusKysel
previously approved these changes
Jul 15, 2025
iurii-ssv
requested changes
Jul 15, 2025
iurii-ssv
left a comment
iurii-ssv
left a comment
Contributor
There was a problem hiding this comment.
Just 1 comment regarding recent GasLimit change
kchojn
previously approved these changes
Jul 15, 2025
oleg-ssvlabs
previously approved these changes
Jul 15, 2025
iurii-ssv
previously approved these changes
Jul 15, 2025
#2402) * implement mutual TLS for all E2E test connections - Add client certificates for E2E test client - Configure Web3Signer to require client certificates - Update SSV-Signer to use proper client certs when connecting to Web3Signer - Refactor certificate generation for clarity and maintainability - Remove unnecessary certificate key path fields from TestEnvironment * copilot suggestions * use dirMode constant
nkryuchkov
dismissed stale reviews from iurii-ssv, oleg-ssvlabs, and kchojn
via
July 15, 2025 23:05
49ac9c0
kchojn
previously approved these changes
Jul 16, 2025
olegshmuelov
previously approved these changes
Jul 16, 2025
MatusKysel
previously approved these changes
Jul 16, 2025
# Conflicts: # scripts/spec-alignment/differ.config.yaml
nkryuchkov
dismissed stale reviews from MatusKysel, olegshmuelov, and kchojn
via
July 17, 2025 13:06
3620734
kchojn
approved these changes
Jul 17, 2025
oleg-ssvlabs
approved these changes
Jul 17, 2025
olegshmuelov
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porting the latest change from
maintostageSupersedes #2352