MEV support - #918
Merged
Merged
Conversation
deploy v3 nodes fix register interval register logs register logs EstimatedTimeAtSlot fix remove log files builder domain cleanup validator reg interval to 10 all nodes support blinded all nodes support blinded validatorRegistrationEpochInterval to 4 blinded support for 9-12 lint fix
# Conflicts: # beacon/goclient/proposer.go # go.sum # operator/validator/controller.go # protocol/v2/blockchain/beacon/beacon_mock.go # protocol/v2/blockchain/beacon/mock_client.go # protocol/v2/ssv/runner/proposer.go # protocol/v2/ssv/runner/validator_registration.go # protocol/v2/ssv/validator/startup.go # protocol/v2/ssv/validator/validator.go
nkryuchkov
marked this pull request as draft
March 29, 2023 14:52
nkryuchkov
marked this pull request as ready for review
May 14, 2023 10:59
y0sher
approved these changes
May 15, 2023
moshe-blox
approved these changes
May 15, 2023
|
|
||
| // only 1 root, verified in basePreConsensusMsgProcessing | ||
| root := roots[0] | ||
| // randao is relevant only for block proposals, no need to check type |
Contributor
There was a problem hiding this comment.
i think this comment can be removed
Contributor
Author
There was a problem hiding this comment.
I wasn't quick enough to remove this and the PR was just merged
| if logger != nil && options.Reporting { | ||
| opt.Logger = newLogger(logger) | ||
| } else { | ||
| opt.Logger = newLogger(zap.NewNop()) // TODO: we should allow only errors to be logged |
Contributor
There was a problem hiding this comment.
did this really solve an issue, or is it just a Git conflict artifact?
Contributor
Author
There was a problem hiding this comment.
I'm not sure, it was done in the Niv's commits, I didn't check this specific line. Do you want to delete this?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #870 and #856
Depends on ssvlabs/ssv-spec#226