Custom terminal shell setting cannot be selected #21586
Description
Problem
On macOS systems whose configured system shell is /bin/tcsh, Settings → Terminal displays the System shell option, but clicking Custom shell does not activate the custom-shell input.
Expected
Selecting Custom shell should reveal an editable shell path field.
Observed
The selection remains on System shell and no input appears.
Environment
- macOS
- Orca local build
A regression test and fix are prepared on branch fix-custom-terminal-shell-setting.
Activity
AmethystLiang commentedon Sep 21, 2026
thanks for reporting. looking into it
Ninerian commentedon Sep 23, 2026
The cause is
orca/src/renderer/src/components/settings/TerminalPane.tsx
Line 130 in e4d8a9d
The value of customShell is initially an empty string which is the same as if the system shell is chosen. Therefore the logic stays in the system shell path.
nwparker commentedon Oct 22, 2026
Verified this is implemented on current
main(4dd97f02d5e240ab5d756017a946f8a9617678c6). Selecting Custom shell now writesconfiguredShell || systemShell, so an initially empty custom setting becomes/bin/tcshand the editable path field appears. This replaces the empty-string selection described above.Evidence:
TerminalPane.tsx; the implementation is included in merged #25078 (dd39dcba5f99710251bac1a33392bb41a1fd3945, ancestor of main). #21587 itself was not merged, so this closure relies on the current implementation.I also ran a temporary React component test against the actual TerminalPane, with the platform shell set to
/bin/tcshand an initially empty setting: selecting Custom shell selected its radio and revealed/bin/tcsh; editing the field changed its value; switching back to System shell hid the field. 1 test passed withORCA_BACKGROUND_LAUNCH=1 pnpm test …. This was a component test, not a desktop app run.Closing as completed because the full reported selection/input behavior is now delivered.