Repository navigation
Conversation
|
Warning Review limit reached
Next review available in: 11 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📥 CommitsReviewing files that changed from the base of the PR and between 48b45d82b32b463f80ba24599f1eb83acb7477df and 3738c18dc13aa79d4b2e72ef50a4dca82438aa98. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a default-enabled 🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6bc5e1be-7a25-4ab3-84a6-ee6ca6fdc066
📥 Commits
Reviewing files that changed from the base of the PR and between 505967e and 48b45d82b32b463f80ba24599f1eb83acb7477df.
📒 Files selected for processing (9)
src/renderer/src/components/settings/AgentsPane.tsxsrc/renderer/src/components/settings/CreatedAgentReopenSetting.tsxsrc/renderer/src/components/settings/agents-search.tssrc/renderer/src/components/settings/created-agent-reopen-copy.tssrc/renderer/src/components/settings/setting-labels.tssrc/renderer/src/lib/worktree-activation-created-agent.test.tssrc/renderer/src/lib/worktree-activation.tssrc/shared/constants.tssrc/shared/types.ts
Workspaces created with an agent relaunched that agent on every empty sidebar reopen. Add Settings → Agents toggle (default on) so users can prefer a blank terminal instead, and label the launch as request_kind new rather than resume since no provider session is restored. Closes stablyai#10578
CodeRabbit: replace the bespoke switch markup with the settings form primitive so interaction and styling stay consistent.
3738c18 to
e9c4b48
Compare
Sync update (
|
Greptile SummaryThis PR implements default-on reopening of workspaces with their creation agent (
Confidence Score: 4/5Safe to merge with the noted caveat — the new agent-reopen path works correctly and the opt-out setting is wired end-to-end, but an existing unfixed tracking issue can cause visit recency to be skipped when the worktree is already active with no tabs. The hasActivationWork guard only checks opts?.startup, so when buildCreatedAgentReopenStartup is the sole source of a startup payload and the worktree is already the active terminal worktree, isPlainAlreadyActiveTerminal evaluates to true, skipping markWorktreeVisited and recordWorktreeVisit. This was flagged in a previous review pass and remains unaddressed. Files Needing Attention: src/renderer/src/lib/worktree-activation.ts — the hasActivationWork calculation and the hardcoded launch_source in buildCreatedAgentReopenStartup.
|
| Filename | Overview |
|---|---|
| src/renderer/src/lib/worktree-activation.ts | Core logic change: adds buildCreatedAgentReopenStartup and wires it into activateAndRevealWorktree; the unaddressed hasActivationWork issue from a previous review remains unfixed. |
| src/renderer/src/lib/worktree-activation-created-agent.test.ts | Tests updated to reflect reversed default behavior; opts-out, WSL quoting, and multi-cycle cases all covered. |
| src/renderer/src/components/settings/CreatedAgentReopenSetting.tsx | New settings component; correctly defaults to enabled via !== false guard. |
| src/shared/types.ts | Adds reopenWorkspacesWithCreatedAgent: boolean to GlobalSettings with JSDoc. |
| src/shared/constants.ts | Default set to true preserving #1814 behaviour; comment references both tracking issues. |
Reviews (2): Last reviewed commit: "fix(settings): align created-agent reope..." | Re-trigger Greptile
Greptile: SETTING_LABELS must match the SettingsSwitchRow title string. Co-Authored-By: Grok Companion <noreply@x.ai>
Sync update (
|
|
Closing in favor of merged #10647, which already closes #10578. Empty-workspace activation no longer synthesizes a startup from |
Summary
createdWithAgentis still stored for history but not auto-launched.request_kind: 'new'(not'resume') because it starts a fresh empty-prompt session.Test plan
vitest—worktree-activation-created-agent.test.ts(13 tests, including opt-out)Closes #10578
ELI5
Reopening an empty workspace used to always relaunch the agent it was created with. A new setting lets you opt out so reopen starts a blank terminal while still remembering which agent created it.