Repository navigation
Conversation
…ns (stablyai#10508) Add a Terminal settings switch (off by default) that visually dims trailing size tokens like 1.4K / 738B in agent listings. Decorations only — the PTY buffer, selection, and copy stay byte-identical.
📝 WalkthroughWalkthroughAdds a persisted “Dim file sizes” terminal preference with load, save, and subscription APIs. The terminal WebView receives preference updates through a new bridge command and applies injected decoration logic to trailing directory-listing size tokens. Decorations refresh after terminal writes and scrolling and clear during disposal. Tests cover preference persistence and notifications, token parsing, invalid inputs, and trailing whitespace. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: f8740e19-6c19-4cc9-adf8-fa8a82d91090
📒 Files selected for processing (9)
mobile/app/terminal-settings.tsxmobile/src/storage/preferences.test.tsmobile/src/storage/preferences.tsmobile/src/terminal/TerminalWebView.tsxmobile/src/terminal/terminal-dir-listing-size-dim-injected.tsmobile/src/terminal/terminal-dir-listing-size-dim.test.tsmobile/src/terminal/terminal-dir-listing-size-dim.tsmobile/src/terminal/terminal-webview-html.tsmobile/src/terminal/terminal-webview-messages.ts
Dispose linked IMarkers with decorations, tint overlays from terminalTheme.background (and refresh after set-theme), and subscribe before the initial load so a live toggle cannot be overridden by a stale AsyncStorage read.
Sync update (
|
Summary
1.4K,738B,45.9K, …) in agent directory listings.Fixes
Closes #10508
Test plan
ELI5
Mobile terminals can optionally dim trailing file-size tokens in directory listings so agent ls output is easier to read. It's visual-only and off by default.