Skip to content

Improve Korean and Chinese sidebar translations - #10664

Closed
AmethystLiang wants to merge 1 commit into
mainfrom
AmethystLiang/improve-translation
Closed

AmethystLiang wants to merge 1 commit into
mainfrom
AmethystLiang/improve-translation

Conversation

@AmethystLiang

Copy link
Copy Markdown
Contributor

Summary

  • Updated the Korean SidebarNav label for the New button to a shorter translation.
  • Updated the Chinese SidebarNav label for the New button to clarify it means new features.
  • Fixed the Chinese translation for the GH PR label, which was incorrectly translated as a biomedical term.

Testing

  • Not run; localization-only changes.

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 07d2d072-59c2-414d-9198-4e7126a4af96

📥 Commits

Reviewing files that changed from the base of the PR and between c06bf64 and 800b21e.

📒 Files selected for processing (2)
  • src/renderer/src/i18n/locales/ko.json
  • src/renderer/src/i18n/locales/zh.json

📝 Walkthrough

Walkthrough

Updated one Korean sidebar label and two Chinese localization labels: the sidebar label and the worktree metadata dialog label.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes Summary and Testing, but it omits the required Screenshots, AI Review Report, Security Audit, and Notes sections. Add the missing template sections, including screenshots or "No visual change", AI review report, security audit, and notes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is relevant and concise for the localization changes, though it doesn't mention the Chinese GH PR label fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

nwparker pushed a commit that referenced this pull request Aug 4, 2026
SidebarNav.c86d83b5c3 is the onboarding pill rendered beside Orca Mobile, so
"New" marks a new feature. Both locales had translated it as a create action —
ko 새로 만들기 ("create new"), zh 新建 ("create new") — which reads as a button.

The PR's other hunk (zh GH PR) already landed on main and resolved to a no-op.

Co-authored-by: Jinjing <6427696+AmethystLiang@users.noreply.github.com>
nwparker added a commit that referenced this pull request Aug 4, 2026
The badge value is pinned in locale-key-overrides.mjs, so the ko/zh fix from
#10664 would have been reverted by the next catalog repair. ja carried the same
defect — 新規 reads as "create new" — and is corrected alongside.
@nwparker

nwparker commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Merged into main via #12514, which consolidated the open community translation work into one branch. Your commit is on main with you as its author — I used a rebase merge specifically so every contributor's commit and co-author trailer survived intact rather than being squashed into one.

Closing this in favour of that. Thank you for the fix, and sorry it took as long as it did to get through.

@nwparker nwparker closed this Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants