fix(i18n): keep ko workspace, worktree, and primary distinct

[Turtle-Hwan]

Fixes #11727.

Problem

Korean copy names the wrong object in delete and remove flows. Remove workspace renders as 워크트리 제거 ("Remove worktree") and Open Parent Worktree as 상위 워크스페이스 열기 ("Open parent workspace") — different objects, removed by different actions. worktree also alternates between 워크트리 and 작업 트리 across 112 strings, and Orca's git primary collapsed into 기본, the word the catalog already uses for default, leaving the primary-worktree badge reading as a default-branch marker.

The catalog is generated, so the fix belongs in the glossary: repair-locale-catalog.mjs rewrites every leaf from config/scripts/, and a hand-edited value would not survive the next run.

Fix

Two commits, reviewable independently.

1 — repairCatalog guard. The repair script could not run at all: it passed undefined into repairTranslatedValue for any en.json key the locale catalog hadn't been bootstrapped with yet (40 today) and crashed in applyBrandMistranslationFixes. Skipping those leaves unblocks it, which also applies 276 leaf updates that already-declared rules had never reached — 작업 공간 → 워크스페이스 among them. This commit is pure tooling repair; the diff it produces is the repo's own policy catching up.

2 — the terminology. A round-6 phrase-fix set pins the vocabulary:

English	한국어
workspace	워크스페이스
worktree	워크트리
primary (worktree, checkout, branch)	주
default (branch, value, behavior)	기본

Rules are guarded on the English source, so a string naming both terms (This workspace cannot be forked into a git worktree.) keeps both, and primary outside the git vocabulary (Primary action clicked, X11 primary selection) keeps 기본. Eight strings needed key overrides where the MT was wrong beyond terminology — Following primary branch (X) had become "the next default branch", and one Linear string carried a corrupted character (단일 Linear �크트리의 ID).

working-tree is deliberately not folded into a third loanword. In UI copy it only ever qualifies a file ("no working-tree file is available to edit"), where what's missing is the file, not the worktree; those three strings are paraphrased. CONTRIBUTING.md now records the contract, including that git's own vocabulary overlaps the two senses and that git stderr matchers must never be translated.

137 leaf updates. No runtime source is touched — locale data plus two offline build scripts.

Validation

• pnpm lint — clean, including all three localization gates
• pnpm typecheck — clean
• pnpm test — 42,085 passed, 3,976 files
• npx vitest run config/scripts/locale-translation-policy-ko-round6.test.mjs — 9 passed
• Re-ran the full en.json ↔ ko.json audit after the change: 0 remaining defects in every class above, the only surviving primary → 기본 pairs being the two intentional non-git ones

The new tests assert the terminology contract, not whole sentences. Full-string equality is used only where the string is a single term (워크트리 삭제, 주); everything else asserts which term must and must not appear, so copy can be reworded later without breaking them while a swapped term still fails immediately. One case pins the repairCatalog guard; one asserts an unmapped working-tree string passes through untouched rather than silently acquiring the wrong term.

Copy changes

No visual change beyond the strings themselves. Representative before/after:

Key	Before	After
TerminalSshReconnectOverlay.removeWorkspaceButton	워크트리 제거	워크스페이스 제거
WorktreeContextMenu.8d9cd19d09	상위 워크스페이스 열기	상위 워크트리 열기
WorktreeContextMenu.deleteWorktree	작업 트리 삭제	워크트리 삭제
WorktreeCard.7d517f82e2 (badge)	기본	주
WorktreeCard.0777de5970 (tooltip)	기본 워크트리(원래 복제 디렉터리)	주 워크트리(원래 복제 디렉터리)
WorktreeContextMenu.primaryDeleteDisabled	기본 작업 트리는 삭제할 수 없습니다	주 워크트리는 삭제할 수 없습니다

Notes

• Cross-platform: nothing platform-dependent is touched — no shortcuts, labels, paths, shell behavior, or Electron APIs. The added rules run only in the offline bootstrap/repair scripts, never at app runtime. One corrected string sits on the SSH reconnect path; the change is copy-only and its handler is untouched.
• Only ko was audited. zh, ja, and es translate through the same context-free path, so the class is likely present there — [Bug]: Chinese translation error: Automation missed-run Grace field mistranslated as “elegance” / “divine grace” #11505 looks like an instance. Kept out of this PR to keep it reviewable.
• verify:localization-catalog and friends check key parity and coverage but not whether a catalog agrees with the glossary, which is how 276 leaves of drift went unnoticed. A repair --check gate would close that; happy to send it separately rather than widen this PR.
• Two unrelated local test flakes worth knowing about: wsl-hook-relay-live.integration.test.ts fails against a stale out/relay/wsl/ bundle because it only rebuilds when the bundle is absent (node config/scripts/build-relay.mjs clears it), and ai-vault-session-worktree-map.test.tsx asserts a 150 ms wall-clock budget that can be exceeded under full-suite parallel load while passing 3/3 in isolation.

X: @turtlehwan

[greptile-apps]

Greptile Summary

This PR fixes Korean i18n terminology confusion between workspace, worktree, and primary — three distinct concepts that had collapsed into overlapping or incorrect renderings — and repairs the repairCatalog script that was crashing on bootstrapped-but-unmapped keys, which had silently blocked 276 previously-declared glossary rules from ever reaching the catalog.

• Tooling fix: repairCatalog now skips en.json keys absent from the locale catalog (typeof current !== 'string' guard) instead of crashing in applyBrandMistranslationFixes. A countCatalogRepairDrifts non-mutating variant enables the new verify:localization-repair CI gate, which keeps ko/ja/zh repair-clean going forward.
• Glossary rules: locale-workspace-worktree-glossary.mjs adds a dedicated repair stage (inserted after phrase fixes, before CJK spacing) that applies English-guarded regex substitutions per locale to enforce workspace/worktree/primary vocabulary. Eight strings with deeper MT errors receive explicit key overrides; working-tree strings are paraphrased rather than coerced into a third loanword.
• Locale data: 137 leaf updates to ko.json, plus corresponding drift cleanup in ja.json and zh.json produced by running the fixed repair script.

Confidence Score: 5/5

Safe to merge — all changes are offline tooling and generated locale data; no runtime source is touched.

The repair pipeline refactoring is clean: the bootstrap guard correctly skips non-string leaves without touching the locale catalog, the applyPolicyRepairs helper faithfully preserves the existing order of brand-fix → phrase-fix → glossary → CJK spacing, and the new CI gate closes the drift detection gap. The English-guard regexes use mutually exclusive conditions (negative lookaheads for the workspace-only / worktree-only cases) so the rules cannot chain-fire on each other. Test coverage exercises every rule path including the two tricky edge cases (dual-term preservation and working-tree passthrough). All 42,085 tests and the three localization gates passed in CI.

Files Needing Attention: No files require special attention.

Important Files Changed

Filename	Overview
config/scripts/locale-workspace-worktree-glossary.mjs	New repair stage implementing English-guarded regex rules for workspace/worktree/primary per locale. Guard logic is mutually exclusive for the workspace-only vs worktree-only cases (negative lookaheads prevent both firing when en names both terms). All rules are exercised by dedicated tests.
config/scripts/locale-translation-policy.mjs	Extracts applyPolicyRepairs helper (deduplicating three identical call chains), inserts applyWorkspaceWorktreeGlossary after phrase fixes, adds repairCatalog bootstrap guard (typeof current !== 'string'), exports countCatalogRepairDrifts for non-mutating CI checks, and adds Continue-action exemptions. Refactoring is clean with no behavioral regression on existing code paths.
config/scripts/repair-locale-catalog.mjs	Adds --check mode (read-only drift detection) with correct exit code 1 on dirty, returns clean boolean in result object, and wires checkOnly through main(). The check-only path loads a Map clone for cache so the original is not mutated.
config/scripts/verify-localization-repair.mjs	New CI gate that uses countCatalogRepairDrifts against ko/ja/zh catalogs and returns exit 1 on any drift. Spanish is deliberately excluded (comment explains bulk MT drift not yet addressed). Wired into the lint script in package.json.
config/scripts/locale-workspace-worktree-glossary-ko.test.mjs	Comprehensive tests covering all ko glossary rules: term swaps (workspace↔worktree), dual-term preservation, primary-vs-default disambiguation, working-tree override pin, phrase-rule passthrough, and the repairCatalog bootstrap guard. Comment on the three working-tree keys clearly attributes the guarantee to key overrides after the previous review thread.
config/scripts/locale-continue-action-exemptions.mjs	New module distinguishing the 'Continue' action button from the Continue agent product name. Correctly exempts multi-word 'Continue in New Session' values and a specific MobileHero key from the brand-revert and never-translate guards.
config/scripts/locale-ko-key-overrides.json	Adds eight key overrides for strings where MT produced errors beyond terminology (primary-branch following, Linear workspace body with corrupted character, working-tree paraphrases). Overrides for BaseRefPicker already use the corrected 주 브랜치 form; RepositoryPane overrides retain 기본 워크트리 for the 'default worktree' (default, not primary) sense.
src/renderer/src/i18n/locales/ko.json	137 leaf updates: 작업 트리 → 워크트리 throughout, workspace/worktree swap corrections, 기본 → 주 on primary-worktree/checkout/branch contexts. Generated by the repair script; spot-checked key cases match the PR's before/after table.
src/renderer/src/i18n/locales/zh.json	Bulk drift cleanup (工作区/工作树 swaps + 主要→主 badge) produced by the unblocked repairCatalog running for the first time. Changes mirror the same glossary logic as ko.
config/scripts/locale-ja-phrase-fixes.mjs	Adds two phrase-fix rules to re-space 'AIagent' gluing caused by the エージェント→agent brand revert. The character-class lookbehind correctly inserts the gap between preceding Japanese and the AI token.
package.json	Adds verify:localization-repair script and appends it to the lint gate, closing the gap where catalog drift went undetected for 276 leaves.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[repairTranslatedValue] --> B{Key override?}
    B -- yes --> C[applyPolicyRepairs\nwith keyOverride value]
    B -- no --> D{Value override?}
    D -- yes --> E[applyPolicyRepairs\nwith valueOverride value]
    D -- no --> F{shouldPreserveEnglishValue?}
    F -- yes --> G[Return enValue unchanged]
    F -- no --> H[applyPolicyRepairs\nwith localeValue]

    subgraph applyPolicyRepairs
        P1[applyBrandMistranslationFixes]
        P2[applyPhraseFixes]
        P3[applyWorkspaceWorktreeGlossary NEW]
        P4[applyCjkLatinTermSpacing]
        P1 --> P2 --> P3 --> P4
    end

    C --> applyPolicyRepairs
    E --> applyPolicyRepairs
    H --> applyPolicyRepairs

Loading

_{Reviews (5): Last reviewed commit: "fix(i18n): Consolidate workspace/worktre..." | Re-trigger Greptile}

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Updated Japanese, Korean, and Chinese renderer catalogs with standardized terminology, spacing, and localized UI messages. Added guarded glossary repairs for workspace, worktree, primary, and AI-agent terms. Added Continue action exemptions and locale overrides. Added catalog drift counting, check-only repair mode, verification commands, tests, package wiring, workflow integration, and localization workflow documentation.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Out of Scope Changes check	⚠️ Warning	The PR includes substantial Japanese and Chinese locale changes and shared Continue-action and CJK verification work not required by the Korean issue [#11727].	Move unrelated Japanese, Chinese, Continue-action, and broader CJK verification changes into separate pull requests.
Docstring Coverage	⚠️ Warning	Docstring coverage is 14.81% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main Korean localization change: preserving distinct workspace, worktree, and primary terminology.
Description check	✅ Passed	The description directly explains the Korean localization defects, implementation, scope, and validation results.
Linked Issues check	✅ Passed	The changes address the reported labels and enforce the requested Korean glossary, primary/default distinction, repair guard, and generated catalog updates [#11727].

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8b1a9bdd-c6b9-461e-99f5-e6943f46c684

📥 Commits

Reviewing files that changed from the base of the PR and between 4f00b21 and e41d6088ee46b3b062367a03998198c6aedab625.

📒 Files selected for processing (8)

• .github/CONTRIBUTING.md
• AGENTS.md
• config/scripts/locale-ko-key-overrides.json
• config/scripts/locale-ko-phrase-fixes-round5.mjs
• config/scripts/locale-ko-phrase-fixes-round6.mjs
• config/scripts/locale-translation-policy-ko-round6.test.mjs
• config/scripts/locale-translation-policy.mjs
• src/renderer/src/i18n/locales/ko.json

[coderabbitai]

Actionable comments posted: 5

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fe237727-a2d7-476f-97f1-c15f0acb4c4d

📥 Commits

Reviewing files that changed from the base of the PR and between e41d6088ee46b3b062367a03998198c6aedab625 and d71191277d1e9fb4bee6bbe884c7f6bc8c95abc8.

📒 Files selected for processing (12)

• .github/CONTRIBUTING.md
• AGENTS.md
• config/scripts/locale-ja-phrase-fixes-round6.mjs
• config/scripts/locale-ja-phrase-fixes.mjs
• config/scripts/locale-translation-policy-ja-round6.test.mjs
• config/scripts/locale-translation-policy-ko-round6.test.mjs
• config/scripts/locale-translation-policy-zh-round6.test.mjs
• config/scripts/locale-zh-phrase-fixes-round5.mjs
• config/scripts/locale-zh-phrase-fixes-round6.mjs
• src/renderer/src/i18n/locales/ja.json
• src/renderer/src/i18n/locales/ko.json
• src/renderer/src/i18n/locales/zh.json

🚧 Files skipped from review as they are similar to previous changes (2)

• .github/CONTRIBUTING.md
• src/renderer/src/i18n/locales/ko.json

[AmethystLiang]

Review summary

Reviewed the full branch (ko/ja/zh terminology guards, Continue-action vs Continue-agent split, catalog repair skip for missing keys, and the shared workspace-worktree-phrase-fixes.mjs consolidation).

What looks solid

• Workspace ≠ worktree and primary ≠ default are enforced via English-guarded phrase rules, so dual-term strings keep both terms.
• Catalogs are repair-idempotent (0 leaf drift on re-run) and pass verify:localization-catalog.
• Continue action buttons translate; agent catalog bare "Continue" stays Latin.
• ja AI agent spacing and zh agent-detection wording regressions from the brand-revert path are fixed and regression-tested.
• Missing-key repairCatalog guard is covered.

Checks run locally

• vitest: ko/ja/zh round6 + continue/AI agent + base policy tests — 40/40 pass
• catalog defect audit (workspace/worktree swaps, glued AIagent, broken 未检测) — clean
• pnpm verify:localization-catalog — clean

No further code changes needed from this review.

[coderabbitai]

🧹 Nitpick comments (2)

config/scripts/verify-localization-repair.mjs (1)

52-54: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

Let validation output flush before exit.

process.exit(await main()) can terminate the process before console.error and console.log output drains through CI pipes. Set process.exitCode instead and let Node.js exit naturally.

Suggested change

 if (process.argv[1] && import.meta.url === pathToFileURL(process.argv[1]).href) {
-  process.exit(await main())
+  process.exitCode = await main()
 }

#!/usr/bin/env bash
set -euo pipefail

node --input-type=module <<'EOF'
import { spawnSync } from 'node:child_process'

for (const mode of ['process.exit(1)', 'process.exitCode = 1']) {
  const source = `process.stderr.write('x'.repeat(1_000_000)); ${mode}`
  const result = spawnSync(process.execPath, ['--input-type=module', '--eval', source], {
    encoding: 'utf8',
  })
  console.log(mode, { status: result.status, bytes: result.stderr.length })
}
EOF

.github/workflows/pr.yml (1)

99-115: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win

Declare read-only permissions for root_directory_guard.

If .github/workflows/pr.yml has no workflow-level restriction, this job can inherit broad GITHUB_TOKEN permissions while executing .github/scripts/check-root-directory-entries.sh. Add contents: read to this job, or verify an equivalent workflow-level restriction.

Suggested change

   root_directory_guard:
     name: root directory guard
     runs-on: ubuntu-latest
+    permissions:
+      contents: read

#!/usr/bin/env bash
set -euo pipefail

sed -n '1,125p' .github/workflows/pr.yml

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 127c9a83-0f21-47b3-9a60-67f554928fb6

📥 Commits

Reviewing files that changed from the base of the PR and between 8595418d1bd7ac6f69b6802550383144f21b7942 and 085b42d763a600516a39f6d8fd290d35d0958229.

📒 Files selected for processing (22)

• .github/CONTRIBUTING.md
• .github/workflows/pr.yml
• config/scripts/locale-continue-action-exemptions.mjs
• config/scripts/locale-continue-action-key-overrides.mjs
• config/scripts/locale-ja-phrase-fixes.mjs
• config/scripts/locale-key-override-merge.mjs
• config/scripts/locale-ko-key-overrides.json
• config/scripts/locale-ko-phrase-fixes-round5.mjs
• config/scripts/locale-translation-policy-continue-and-ai-agent.test.mjs
• config/scripts/locale-translation-policy.mjs
• config/scripts/locale-value-overrides.mjs
• config/scripts/locale-workspace-worktree-glossary-ja.test.mjs
• config/scripts/locale-workspace-worktree-glossary-ko.test.mjs
• config/scripts/locale-workspace-worktree-glossary-zh.test.mjs
• config/scripts/locale-workspace-worktree-glossary.mjs
• config/scripts/locale-workspace-worktree-glossary.test.mjs
• config/scripts/locale-zh-phrase-fixes-round5.mjs
• config/scripts/localization-package-contract.test.mjs
• config/scripts/repair-locale-catalog.mjs
• config/scripts/verify-localization-repair.mjs
• config/scripts/verify-localization-repair.test.mjs
• package.json

🚧 Files skipped from review as they are similar to previous changes (20)

• config/scripts/locale-zh-phrase-fixes-round5.mjs
• package.json
• config/scripts/locale-continue-action-key-overrides.mjs
• config/scripts/locale-key-override-merge.mjs
• config/scripts/locale-workspace-worktree-glossary-ja.test.mjs
• config/scripts/verify-localization-repair.test.mjs
• config/scripts/locale-continue-action-exemptions.mjs
• config/scripts/locale-workspace-worktree-glossary.test.mjs
• config/scripts/locale-workspace-worktree-glossary-zh.test.mjs
• config/scripts/locale-workspace-worktree-glossary-ko.test.mjs
• config/scripts/repair-locale-catalog.mjs
• config/scripts/locale-workspace-worktree-glossary.mjs
• .github/CONTRIBUTING.md
• config/scripts/locale-ja-phrase-fixes.mjs
• config/scripts/locale-value-overrides.mjs
• config/scripts/locale-translation-policy-continue-and-ai-agent.test.mjs
• config/scripts/locale-ko-key-overrides.json
• config/scripts/locale-ko-phrase-fixes-round5.mjs
• config/scripts/locale-translation-policy.mjs
• config/scripts/localization-package-contract.test.mjs

[nwparker]

Thanks for catching this — the crash is real and reproduces on main: node config/scripts/repair-locale-catalog.mjs --locale=ko throws TypeError: Cannot read properties of undefined (reading 'replace') in applyCjkLatinTermSpacing. en.json carries 188 ko / 193 ja / 183 zh / 193 es keys the locale catalogs were never bootstrapped with, and repairCatalog only ever rewrites values that already exist, so the guard belongs there.

I've split the fix out on its own with a regression test and credited you as the author — it's in #12514. I left the catalog regeneration your PR also carried out of that branch so the guard can land on its own; happy to take the regeneration as a follow-up.

Sorry for the slow turnaround on this one.

[nwparker]

Merged into main via #12514, which consolidated the open community translation work into one branch. Your commit is on main with you as its author — I used a rebase merge specifically so every contributor's commit and co-author trailer survived intact rather than being squashed into one.

Closing this in favour of that. Thank you for the fix, and sorry it took as long as it did to get through.