Repository navigation
fix(i18n): localize automation contextual tour #12270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b664f1c
fix(i18n): localize automation contextual tour
5Hyeons bba6f6d
fix(i18n): correct automation results copy
5Hyeons 09003f6
fix(i18n): key tour copy off the step id, not its position
5Hyeons 3af175c
style(contextual-tours): condense stable-id rationale comments
5Hyeons File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
...nderer/src/components/contextual-tours/ContextualTourOverlaySurface.localization.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| // @vitest-environment happy-dom | ||
|
|
||
| import type { ReactElement, RefObject } from 'react' | ||
| import { renderToStaticMarkup } from 'react-dom/server' | ||
| import { afterEach, describe, expect, it, vi } from 'vitest' | ||
| import { setRendererUiLanguage } from '@/i18n/i18n' | ||
| import { | ||
| ContextualTourOverlaySurface, | ||
| handleContextualTourOverlayKeyDown, | ||
| type ActiveTourRenderState | ||
| } from './ContextualTourOverlaySurface' | ||
|
|
||
| afterEach(async () => { | ||
| await setRendererUiLanguage('en') | ||
| }) | ||
|
|
||
| function renderSurface(isLastStep: boolean): ReactElement { | ||
| const panelRef: RefObject<HTMLElement | null> = { current: null } | ||
| const renderState: ActiveTourRenderState = { | ||
| rect: new DOMRect(0, 0, 20, 20), | ||
| targetElement: document.createElement('button'), | ||
| progress: { current: isLastStep ? 2 : 1, total: 2 }, | ||
| title: 'Tour title', | ||
| body: 'Tour body', | ||
| isLastStep, | ||
| isFirstStep: !isLastStep, | ||
| panelHost: null | ||
| } | ||
| return ( | ||
| <ContextualTourOverlaySurface | ||
| activeTourId="automations" | ||
| renderState={renderState} | ||
| panelRef={panelRef} | ||
| panelHost={null} | ||
| onSkip={vi.fn()} | ||
| onBack={vi.fn()} | ||
| onNext={vi.fn()} | ||
| onStepAction={vi.fn()} | ||
| onOverlayKeyDownCapture={handleContextualTourOverlayKeyDown} | ||
| /> | ||
| ) | ||
| } | ||
|
|
||
| describe('ContextualTourOverlaySurface localization', () => { | ||
| it('renders default tour actions in Korean when the UI locale is Korean', async () => { | ||
| await setRendererUiLanguage('ko') | ||
|
|
||
| const firstStep = renderToStaticMarkup(renderSurface(false)) | ||
| const finalStep = renderToStaticMarkup(renderSurface(true)) | ||
|
|
||
| expect(firstStep).toContain('다음') | ||
| expect(firstStep).not.toContain('>Next<') | ||
| expect(finalStep).toContain('완료') | ||
| expect(finalStep).not.toContain('>Done<') | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 changes: 93 additions & 1 deletion
94
src/renderer/src/components/contextual-tours/contextual-tour-overlay-measurement.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.