Skip to content

fix(i18n): correct ja Push/Pull button translations - #12301

Closed
Iris-Fla wants to merge 1 commit into
stablyai:mainfrom
Iris-Fla:fix-japanese-push-translation
Closed

Iris-Fla wants to merge 1 commit into
stablyai:mainfrom
Iris-Fla:fix-japanese-push-translation

Conversation

@Iris-Fla

@Iris-Fla Iris-Fla commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Source control の Push/Pull ボタンの日本語訳を修正 (押す/引く → プッシュ/プル)。

Screenshots

No visual change (text-only translation fix).

Testing

  • pnpm lint
  • pnpm typecheck
  • pnpm test
  • pnpm build (skipped: text-only i18n change, verified via lint/typecheck/test)
  • Added regression test (ja-technical-literal-mistranslations.test.ts)

AI Review Report

AI-assisted fix: two mistranslated locale strings + a regression test. No code paths touched; risk limited to Japanese locale string content.

Security Audit

No input handling, execution, auth, or dependency changes — static locale string edit only.

Notes

@Iris_Flandre

Source control primary actions used 押す ("press") and 引く ("pull
physically") for Push/Pull instead of the standard loanwords, which
also disagreed with the sibling フォースプッシュ (Force Push) label.
@Iris-Fla
Iris-Fla requested a review from brennanb2025 as a code owner August 3, 2026 12:30
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ebe943b9-cb74-434e-8fcc-6a0e34ec5e30

📥 Commits

Reviewing files that changed from the base of the PR and between e08eba6 and c73b703.

📒 Files selected for processing (2)
  • src/renderer/src/i18n/ja-technical-literal-mistranslations.test.ts
  • src/renderer/src/i18n/locales/ja.json

📝 Walkthrough

Walkthrough

Updated the Japanese locale translations for source-control push and pull actions. Added a Vitest test that recursively locates locale keys and verifies the translations are プッシュ and プル.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the Japanese Push/Pull translation fix.
Description check ✅ Passed The description covers the required sections and accurately reports the translation change, tests, and security impact.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

nwparker pushed a commit that referenced this pull request Aug 4, 2026
The source-control primary action rendered 押す ("press") and 引く ("pull a
physical object") for Push/Pull. プッシュ/プル match the sibling フォースプッシュ
and 同期 labels. A guard test pins both so bootstrap re-translation cannot
silently regress them.

Co-authored-by: Iris-Fla <103801589+Iris-Fla@users.noreply.github.com>
@nwparker

nwparker commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Merged into main via #12514, which consolidated the open community translation work into one branch. Your commit is on main with you as its author — I used a rebase merge specifically so every contributor's commit and co-author trailer survived intact rather than being squashed into one.

Closing this in favour of that. Thank you for the fix, and sorry it took as long as it did to get through.

@nwparker nwparker closed this Aug 4, 2026
enrick-dev pushed a commit to enrick-dev/orca that referenced this pull request Oct 15, 2026
The source-control primary action rendered 押す ("press") and 引く ("pull a
physical object") for Push/Pull. プッシュ/プル match the sibling フォースプッシュ
and 同期 labels. A guard test pins both so bootstrap re-translation cannot
silently regress them.

Co-authored-by: Iris-Fla <103801589+Iris-Fla@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants