Repository navigation
fix(i18n): translate remaining zh.json strings - #12368
qiuyongjin wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdated the Chinese locale with translations for workspace, browser, integration, skill, remote-server, terminal, dashboard, certificate, and runtime messages. Added voice microphone settings and localized image attachment validation, plugin provenance, GitHub refresh states, remote-server errors, and Orca CLI startup guidance. Adjusted existing Chinese punctuation and editor setting descriptions. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 7c8b78c9-89ee-419b-b830-15e830c55a0a
📒 Files selected for processing (1)
src/renderer/src/i18n/locales/zh.json
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
185 zh values were still verbatim English, plus the 6 VoiceMicrophoneSetting keys were missing. Placeholders, "X of Y" counts, and key ordering are unchanged; the only edits to already-translated values are punctuation. Applied at key level rather than as a branch merge — the PR was cut from an older base and conflicted only on JSON context, with no value drift against main. Co-authored-by: 闲人 <38777313+qiuyongjin@users.noreply.github.com> Co-authored-by: jake <qiu5630@163.com>
The browser.loadFailure.* keys were still raw English in es/ja/ko/zh. en.json is
untouched; every {{value0}} token and the Orca/HTTPS brand terms are preserved.
13 of the zh keys were already covered by #12368, so only the 6 it did not
reach are taken here.
Co-authored-by: MumuTW <42820974+MumuTW@users.noreply.github.com>
|
Merged into Closing this in favour of that. Thank you for the fix, and sorry it took as long as it did to get through. |
Summary
src/renderer/src/i18n/locales/zh.jsonacross remote/SSH workspaces, Linear and Jira integration prompts, cookie import, the skill updater, GitHub panels, browser certificate errors, runtime RPC startup, dashboards, settings, the plugin marketplace, and terminal panes.VoiceMicrophoneSettingsettings block, matching the en.json keys 1:1.Screenshots
No visual change — text-only localization update.
Testing
pnpm lint— full pipeline passed locally, includingverify:localization-catalog,verify:localization-extraction, andverify:localization-coverage(12 allowlisted candidates, unchanged).locale-english-regressionandzh-technical-literal-mistranslations.{{value0}},{count},{{host}}:{{port}},{{chord}},{{guidance}},{{cause}}, and\n\nall preserved;{count}correctly kept as single braces).pnpm typecheck/pnpm test/pnpm build— not run locally; JSON-only change touches no code paths, and CI (pr.yml) runs the full suite on this PR.AI Review Report
The full diff was reviewed with an AI review pass:
VoiceMicrophoneSettingblock matches 1:1); placeholder integrity checked against en.json — 0 mismatches file-wide.feedback.image.attachments.fallbackNamewas still English while its block was translated — now "图片附件".Security Audit
No code, input handling, command execution, path handling, auth, secrets, dependency, or IPC changes — locale JSON values only. No new attack surface; no follow-up needed.
Notes