Skip to content

fix(i18n): translate remaining zh.json strings - #12368

Closed
qiuyongjin wants to merge 2 commits into
stablyai:mainfrom
qiuyongjin:fix/i18n-zh-translations
Closed

qiuyongjin wants to merge 2 commits into
stablyai:mainfrom
qiuyongjin:fix/i18n-zh-translations

Conversation

@qiuyongjin

Copy link
Copy Markdown
Contributor

Summary

  • Completes Simplified Chinese (zh) localization: translates ~190 remaining English strings in src/renderer/src/i18n/locales/zh.json across remote/SSH workspaces, Linear and Jira integration prompts, cookie import, the skill updater, GitHub panels, browser certificate errors, runtime RPC startup, dashboards, settings, the plugin marketplace, and terminal panes.
  • Adds the missing VoiceMicrophoneSetting settings block, matching the en.json keys 1:1.
  • Localization-only change — no code or behavior changes.

Screenshots

No visual change — text-only localization update.

Testing

  • pnpm lint — full pipeline passed locally, including verify:localization-catalog, verify:localization-extraction, and verify:localization-coverage (12 allowlisted candidates, unchanged).
  • All i18n tests — 9 files / 68 tests passed, including locale-english-regression and zh-technical-literal-mistranslations.
  • JSON validity and placeholder parity vs en.json — 0 mismatches across the whole file ({{value0}}, {count}, {{host}}:{{port}}, {{chord}}, {{guidance}}, {{cause}}, and \n\n all preserved; {count} correctly kept as single braces).
  • pnpm typecheck / pnpm test / pnpm build — not run locally; JSON-only change touches no code paths, and CI (pr.yml) runs the full suite on this PR.
  • No new tests needed — the existing localization gates and zh regression tests cover value-only locale changes.

AI Review Report

The full diff was reviewed with an AI review pass:

  • Correctness: JSON validated; key parity vs en.json checked (the new VoiceMicrophoneSetting block matches 1:1); placeholder integrity checked against en.json — 0 mismatches file-wide.
  • Translation quality: terminology kept consistent with existing zh.json (e.g. "API 令牌" aligned with the existing field label; both "Rich Markdown Spellcheck" occurrences translated identically; sentence fragments that continue an earlier line keep a trailing colon, matching the English "for" pattern).
  • Cross-platform (macOS / Linux / Windows): no code, shortcuts, labels, paths, or shell behavior touched — locale data only, applied identically on all platforms. Strings about remote/SSH/agent/git-provider features are translated text only; no behavior changed.
  • One in-diff oversight found and fixed: feedback.image.attachments.fallbackName was still English while its block was translated — now "图片附件".

Security Audit

No code, input handling, command execution, path handling, auth, secrets, dependency, or IPC changes — locale JSON values only. No new attack surface; no follow-up needed.

Notes

  • 139 keys present in en.json but missing from zh.json are pre-existing gaps (ko.json has a similar set; the coverage audit allowlists them) — out of scope for this PR and suitable as a follow-up.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6ec38084-ab46-491a-9ec7-8f8e81171967

📥 Commits

Reviewing files that changed from the base of the PR and between 1170984 and 82dff90.

📒 Files selected for processing (1)
  • src/renderer/src/i18n/locales/zh.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/renderer/src/i18n/locales/zh.json

📝 Walkthrough

Walkthrough

Updated the Chinese locale with translations for workspace, browser, integration, skill, remote-server, terminal, dashboard, certificate, and runtime messages. Added voice microphone settings and localized image attachment validation, plugin provenance, GitHub refresh states, remote-server errors, and Orca CLI startup guidance. Adjusted existing Chinese punctuation and editor setting descriptions.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the translation of remaining Chinese locale strings.
Description check ✅ Passed The description covers all required sections and documents scope, testing, review, security, platform compatibility, and follow-up items.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7c8b78c9-89ee-419b-b830-15e830c55a0a

📥 Commits

Reviewing files that changed from the base of the PR and between 98e8d1c and 1170984.

📒 Files selected for processing (1)
  • src/renderer/src/i18n/locales/zh.json

Comment thread src/renderer/src/i18n/locales/zh.json Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
nwparker pushed a commit that referenced this pull request Aug 4, 2026
185 zh values were still verbatim English, plus the 6 VoiceMicrophoneSetting
keys were missing. Placeholders, "X of Y" counts, and key ordering are
unchanged; the only edits to already-translated values are punctuation.

Applied at key level rather than as a branch merge — the PR was cut from an
older base and conflicted only on JSON context, with no value drift against
main.

Co-authored-by: 闲人 <38777313+qiuyongjin@users.noreply.github.com>
Co-authored-by: jake <qiu5630@163.com>
nwparker pushed a commit that referenced this pull request Aug 4, 2026
The browser.loadFailure.* keys were still raw English in es/ja/ko/zh. en.json is
untouched; every {{value0}} token and the Orca/HTTPS brand terms are preserved.

13 of the zh keys were already covered by #12368, so only the 6 it did not
reach are taken here.

Co-authored-by: MumuTW <42820974+MumuTW@users.noreply.github.com>
@nwparker

nwparker commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Merged into main via #12514, which consolidated the open community translation work into one branch. Your commit is on main with you as its author — I used a rebase merge specifically so every contributor's commit and co-author trailer survived intact rather than being squashed into one.

Closing this in favour of that. Thank you for the fix, and sorry it took as long as it did to get through.

@nwparker nwparker closed this Aug 4, 2026
@qiuyongjin
qiuyongjin deleted the fix/i18n-zh-translations branch August 5, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants