Repository navigation
fix(i18n): localize the remaining contextual tour steps #12713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
5Hyeons
wants to merge
4
commits into
stablyai:main
Choose a base branch
from
5Hyeons:fix/localize-remaining-contextual-tours
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
60ba6c2
fix(i18n): localize the remaining contextual tour steps
5Hyeons dcd396b
fix(i18n): translate the contextual tour steps for es, ja, and zh
5Hyeons b10f808
fix(i18n): require step ids and correct the Spanish tour labels
5Hyeons 3f406b5
fix(i18n): polish the Korean floating workspace tour copy
5Hyeons File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
src/renderer/src/components/contextual-tours/contextual-tour-step-copy.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| // @vitest-environment happy-dom | ||
|
|
||
| import { afterEach, describe, expect, it } from 'vitest' | ||
| import { CONTEXTUAL_TOURS, type ContextualTour } from '../../../../shared/contextual-tours' | ||
| import { setRendererUiLanguage } from '@/i18n/i18n' | ||
| import { getLocalizedContextualTourStepCopy } from './contextual-tour-step-copy' | ||
|
|
||
| afterEach(async () => { | ||
| await setRendererUiLanguage('en') | ||
| }) | ||
|
|
||
| describe('contextual tour step copy', () => { | ||
| it('translates every tour step, so no step falls back to English mid-tour', async () => { | ||
| await setRendererUiLanguage('ko') | ||
|
|
||
| for (const tour of CONTEXTUAL_TOURS as readonly ContextualTour[]) { | ||
| for (const step of tour.steps) { | ||
| const copy = getLocalizedContextualTourStepCopy(step.id) | ||
| expect(copy, `${tour.id} step "${step.title}" has no localized copy`).toBeDefined() | ||
| expect(copy?.title).not.toBe(step.title) | ||
| expect(copy?.body).not.toBe(step.body) | ||
| if (step.primaryAction) { | ||
| expect(copy?.primaryActionLabel).toBeDefined() | ||
| expect(copy?.primaryActionLabel).not.toBe(step.primaryAction.label) | ||
| } | ||
| } | ||
| } | ||
| }) | ||
|
|
||
| it('renders the floating workspace copy in Korean', async () => { | ||
| await setRendererUiLanguage('ko') | ||
|
|
||
| expect(getLocalizedContextualTourStepCopy('floating-workspace-scratchpad')?.title).toBe( | ||
| '메모장처럼 사용하기' | ||
| ) | ||
| }) | ||
|
|
||
| it('falls back to English copy for the active locale', () => { | ||
| expect(getLocalizedContextualTourStepCopy('floating-workspace-repos')?.title).toBe( | ||
| 'Run an agent across every repo' | ||
| ) | ||
| }) | ||
| }) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.