Repository navigation
fix(runtime): close restored PTYs with missing tabs - #12905
Closed
jarbas-marco wants to merge 1 commit into
Closed
jarbas-marco wants to merge 1 commit into
jarbas-marco wants to merge 1 commit into
Conversation
jarbas-marco
force-pushed
the
jarbas-marco/system-config-maintenance-20260805
branch
from
August 6, 2026 11:18
9ec427c to
d2b3c66
Compare
Contributor
|
Closing this submitted branch as the same missing-persisted-tab behavior is already represented by canonical PR #12922, which remains the owner implementation path. We will not merge this duplicate branch; the diagnosis and contribution remain credited to @jarbas-marco. No action is requested from you. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orca terminal closefor restored live PTYs whose renderer tab no longer exists in persisted session state.tab_not_founderror; every other error still surfaces.Screenshots
No visual change
Testing
pnpm lint(targetedoxfmt --check,oxlint, and changed-code quality gate passed)pnpm typecheckpnpm test(targeted runtime/shared/CLI tests passed: 13 tests)pnpm buildPost-rebase verification:
AI Review Report
Reviewed the rebased diff against
origin/main. The review checked exact-handle behavior, split-pane safety, durable-session/renderer-graph divergence, error narrowing, and agent-team cleanup. Only the literaltab_not_foundcondition takes the PTY fallback; other failures are rethrown. The fallback delegates to the existing handle-scoped close path, so sibling panes are not selected for termination.Cross-platform compatibility was checked for macOS, Linux, and Windows. This change is confined to Electron main-runtime state handling and uses the existing PTY controller abstraction; it adds no shortcuts, labels, paths, shell behavior, or platform-specific branches.
Security Audit
No new IPC surface, command execution, path handling, authentication, secret handling, or dependency was introduced. Existing RPC authorization and terminal-handle resolution remain in place. The catch is intentionally exact so unrelated runtime or persistence failures are not hidden.
Notes
The fault was reproduced against packaged Orca 1.4.173 and 1.4.174-rc.0. Inspection of the 1.4.175 source found the same affected path. No installed application bundle was hotpatched.