Repository navigation
Conversation
|
Warning Review limit reached
Next review available in: 57 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughWorktree deletion now resolves repositories with optional execution host IDs. Removal dialogs receive and use host-scoped repository information. Project removal supports explicit host selection and unique cross-host matches. Ambiguous or missing matches do not trigger removal. Contained projects and orphaned runtime-SSH repositories pass host-specific removal data. Tests cover modal payloads and cross-host repositories with duplicate IDs. 🚥 Pre-merge checks | ✅ 1 | ❌ 4❌ Failed checks (4 warnings)
✅ Passed checks (1 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 2dee5a2e-6ded-4890-847a-bcd05ffd164f
📥 Commits
Reviewing files that changed from the base of the PR and between 66aed16 and 369d798a61870ad60ee05faa6c2f3961292de54d.
📒 Files selected for processing (7)
src/renderer/src/components/sidebar/RemoveFolderDialog.tsxsrc/renderer/src/components/sidebar/WorktreeList.tsxsrc/renderer/src/components/sidebar/delete-worktree-flow.test.tssrc/renderer/src/components/sidebar/delete-worktree-flow.tssrc/renderer/src/components/sidebar/worktree-delete-repo-resolve.tssrc/renderer/src/store/slices/repos-cross-host-project-collisions.test.tssrc/renderer/src/store/slices/repos.ts
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6e45144b-ca16-4cf7-bf57-5c0fc56b6a3c
📥 Commits
Reviewing files that changed from the base of the PR and between 369d798a61870ad60ee05faa6c2f3961292de54d and bd9990ab652c56cf74e31d29d2cccac72a02f579.
📒 Files selected for processing (6)
src/renderer/src/components/sidebar/RemoveFolderDialog.tsxsrc/renderer/src/components/sidebar/delete-worktree-flow.tssrc/renderer/src/components/sidebar/worktree-delete-main-project-remove.tssrc/renderer/src/store/slices/repos-cross-host-project-collisions.test.tssrc/renderer/src/store/slices/repos.tssrc/renderer/src/store/slices/worktrees.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- src/renderer/src/components/sidebar/RemoveFolderDialog.tsx
- src/renderer/src/store/slices/repos.ts
4ce8a7a to
dea83c9
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Ready for review (contributor priority pack)
Part of a short priority list for maintainers: P0 |
Sidebar confirm-remove dropped host identity, so findRepoForHost fell back to a unique survivor id and could destroy the wrong host's project. Pass hostId from the opener, resolve labels/repos by host, and refuse bare-id unique-id fallbacks on remove. Fixes stablyai#13071.
Bare removeProject now uses findRepoForHost (unique any-host + focused disambiguation) so unique SSH rows work under local/runtime focus. Group delete and orphan purge pass hostId; main-worktree confirm refuses when the host cannot be resolved. Addresses review on stablyai#13536
Same repo id on two destroyed hosts must not let a purge of one suppress cleanup of the other. Track purged keys as hostId+repoId. Addresses review on stablyai#13536
dea83c9 to
9d8c55a
Compare
|
Closing because #14359 has landed the original #13071 sidebar/modal host-routing fix. A current-main audit found that the remaining orphan-purge portion overlaps #13117, while this branch’s group-removal approach would remove every host copy sharing a repo id, including copies outside the deleted group. Recasting this PR would therefore be a different fix and would overlap #13117/#13229. The remaining orphan/group paths need host-qualified |
3 participants
Summary
repoId, so when the same id existed on two hosts (or a twin vanished from the catalog)findRepoForHostcould pick the wrong row.hostIdthroughconfirm-remove-folder(WorktreeList + main-worktree delete path), resolve dialog labels/repos by host, and makeremoveProjectrefuse unique-id-any-host fallback whenhostIdis omitted (focused-host match only).Test plan
Fixes #13071