Repository navigation
Conversation
… is not a valid git config path (stablyai#15409) The file's git helper pointed GIT_CONFIG_GLOBAL and GIT_CONFIG_SYSTEM at os.devNull to isolate config. On Windows that constant is a device path (\.\nul) which Git for Windows normalizes to //./nul and rejects ("fatal: unable to access '//./nul': Invalid argument"), so every git call in the file failed and 15 of its 19 tests went red. On Linux and macOS the same constant is /dev/null, which Git accepts — CI stayed green and hid the breakage. The two variables now point at real empty files in a temp directory, which works on every platform and Git version (the approach the issue notes other suites already use). The afterEach also guards the warn mockRestore and repo teardown that threw a secondary TypeError when beforeEach failed before assigning them. Verified on Windows 11 + Git for Windows where the file previously failed: 19/19 passing.
) The Korean README's Android line was synced before stablyai#14978 added the Install guide link next to the APK download in the English README. Adds the matching 설치 가이드 link, using the same terminology as the file's other guide links.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe Korean README adds an installation guide link for the Android Companion APK. The worktree Git tests replace device-path configuration values with empty temporary configuration files. The tests also add cleanup for the shared configuration directory and guard optional warning restoration and repository removal. Merge Risk: ⚪ Minimal · up to The PR adds a Korean README installation-guide link and updates a Git test fixture; a possible commit-identity setup issue is confined to test execution, so no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Warning |
|
Thanks for this, @yzxcj797 — the Korean README gap was a real miss. The same install-guide link already landed on This note is from an automated scan of open PRs whose issue already shipped in a later merge. If that's wrong, please reopen and say so. |
2 participants
Closes #15395.
The Korean README was synced in #14124, before #14978 added the Install guide link next to the Android APK download in the English README. This adds the matching
설치 가이드link at the corresponding line, using the same terminology as the file's other guide links (e.g. the headless Linux server guide). Doc-only.