Skip to content

fix(i18n): standardize Simplified Chinese product terminology - #15464

Draft
ansonlotiniat wants to merge 1 commit into
stablyai:mainfrom
ansonlotiniat:codex/standardize-zh-product-terminology
Draft

ansonlotiniat wants to merge 1 commit into
stablyai:mainfrom
ansonlotiniat:codex/standardize-zh-product-terminology

Conversation

@ansonlotiniat

Copy link
Copy Markdown

ELI5

Orca used several different Chinese words for the same core product concepts. This standardizes the existing Simplified Chinese UI glossary without adding a locale or changing the localization architecture.

What Changed

  • Standardizes the reviewed zh terms: agent → 智能体, terminal → 终端, repo/repository → 仓库, review → 评审, issue → 议题, worktree → 工作树, and workspace → 工作区.
  • Updates the existing exact-value, key, search-keyword, and narrowly guarded phrase overrides.
  • Applies those rules to 63 current zh.json leaves only; unrelated repair-policy drift is excluded.
  • Keeps network proxy → 代理 and HTTP User-Agent → 用户代理 distinct from the AI-agent term.
  • Adds regression coverage for the glossary, legacy forms, and the proxy/User-Agent boundaries.

Why

This is the focused glossary-only follow-up requested in #8923. The original draft combined a complete catalog rewrite, a new zh-TW locale, OpenCC, and verifier/bootstrap changes, which was not reviewable as one unit.

Current main already uses 智能体 in most catalog entries, but the existing repair policy still rewrote some values back to 代理. Repository, review, issue, terminal, and worktree copy also retained a smaller set of conflicting forms. This PR fixes that live inconsistency inside the existing override architecture.

Linked Issue

Follow-up to #8923, specifically the maintainer direction in #8923 (comment).

Visual Proof

Representative before/after copy:

Concept Before After
Agent 代理 / 特工 / 检测剂 智能体
Terminal 浮动码头 浮动终端
Repository 存储库 仓库
Review 审查 / 审核 / 托管评论 评审 / 托管评审
Issue 新一期 / 问题 新建议题 / 议题
Worktree worktree / 工作区(in worktree labels) 工作树

No screenshots: this changes locale copy and repair policy only, with no layout or interaction changes.

Testing

  • I manually tested these changes locally
  • Automated tests added/updated, or explained why not below

Validated on Node 24.18.0:

  • 13 focused localization test files: 67 tests passed.
  • verify-localization-catalog.mjs passed for all existing locale catalogs.
  • verify-localization-extraction.mjs passed.
  • Localization coverage passed with the existing 12 allowlisted candidates.
  • Focused oxlint, oxfmt --check, max-lines ratchet, and git diff --check passed.
  • A catalog scope audit confirmed all 63 changed leaves are glossary-bound; no unrelated full-repair output is included.

Manual app QA was not run because this is a string-policy/catalog-only change. The exact runtime values are committed in zh.json and covered by policy tests.

AI Disclosure

OpenAI Codex (GPT-5) was used to extract the glossary-only patch from the human-reviewed #8923 work, apply it to current main, update tests, and run validation. The terminology decisions come from the contributor-reviewed glossary and the maintainer's requested scope.

Review

Scope is deliberately limited to the existing Simplified Chinese override architecture:

  • no new locale;
  • no OpenCC or other dependency;
  • no bootstrap or verifier rewrite;
  • no zh-TW catalog;
  • no unrelated product-copy replacement.

Agent skill upstream boundary

  • Not applicable, or this change follows docs/reference/agent-skill-sharing-upstream-boundary.md and copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.

Notes

No security, permission, path, platform, SSH/remote, mobile-runtime, backwards-compatibility, or performance behavior changes. Shared catalog consumers receive the same standardized copy.

Checklist

  • This PR is small and focused
  • I explained what changed and why (including ELI5)
  • Before/after proof is included above; screenshots are N/A because layout and interactions are unchanged
  • Self-reviewed for correctness, security, and performance
  • Cross-platform, SSH/remote, and path/shortcut impact considered (N/A for locale-only values)
  • Full pnpm lint, pnpm typecheck, pnpm test, and pnpm build are left to CI; focused localization checks passed locally

Author

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant