Repository navigation
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ➖ Normal Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to
|
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/main/rate-limits/service.ts (1)
2106-2113: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winCache unlimited Codex state during account switches.
Line 2107 defines unlimited usage as valid prior data.
refreshForCodexAccountChangestill caches the outgoing account only whensessionorweeklyexists. A Business unlimited account has neither window, so its inactive roster entry loses usage state after an account switch until a later successful refresh. Includethis.state.codex?.isUnlimitedin that cache condition.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 15375a95-eca7-43b2-8dd5-6012916bad22
📥 Commits
Reviewing files that changed from the base of the PR and between b55836d and cf87b410024aa88e471b5b677ab866b6d96085ac.
📒 Files selected for processing (17)
src/main/rate-limits/codex-fetcher-backend.test.tssrc/main/rate-limits/codex-fetcher.test.tssrc/main/rate-limits/codex-fetcher.tssrc/main/rate-limits/service-refresh-orchestration.test.tssrc/main/rate-limits/service.tssrc/renderer/src/components/status-bar/StatusBar.tsxsrc/renderer/src/components/status-bar/codex-status-sign-in.test.tsxsrc/renderer/src/components/status-bar/inline-usage-bars.test.tsxsrc/renderer/src/components/status-bar/provider-segment-monthly-window.test.tsxsrc/renderer/src/components/status-bar/status-bar-provider-visibility.test.tssrc/renderer/src/components/status-bar/status-bar-provider-visibility.tssrc/renderer/src/components/status-bar/tooltip.test.tssrc/renderer/src/components/status-bar/tooltip.tsxsrc/renderer/src/components/status-bar/usage-roster-row-state.test.tssrc/renderer/src/components/status-bar/usage-roster-row-state.tssrc/renderer/src/i18n/locales/en.jsonsrc/shared/rate-limit-types.ts
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d1de5f1b-81ed-4931-b210-ac4cf202dbbb
📥 Commits
Reviewing files that changed from the base of the PR and between b55836d and ca0d3641a7af91df7fb0b688447df7c5e64f06db.
📒 Files selected for processing (18)
src/main/rate-limits/codex-fetcher-backend.test.tssrc/main/rate-limits/codex-fetcher.test.tssrc/main/rate-limits/codex-fetcher.tssrc/main/rate-limits/service-account-target-selection.test.tssrc/main/rate-limits/service-refresh-orchestration.test.tssrc/main/rate-limits/service.tssrc/renderer/src/components/status-bar/StatusBar.tsxsrc/renderer/src/components/status-bar/codex-status-sign-in.test.tsxsrc/renderer/src/components/status-bar/inline-usage-bars.test.tsxsrc/renderer/src/components/status-bar/provider-segment-monthly-window.test.tsxsrc/renderer/src/components/status-bar/status-bar-provider-visibility.test.tssrc/renderer/src/components/status-bar/status-bar-provider-visibility.tssrc/renderer/src/components/status-bar/tooltip.test.tssrc/renderer/src/components/status-bar/tooltip.tsxsrc/renderer/src/components/status-bar/usage-roster-row-state.test.tssrc/renderer/src/components/status-bar/usage-roster-row-state.tssrc/renderer/src/i18n/locales/en.jsonsrc/shared/rate-limit-types.ts
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.
ca0d364 to
e1b56ad
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
This comment has been minimized.
This comment has been minimized.
|
e1b56ad to
d0642c7
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
d0642c7 to
9269ab2
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
7355b43 to
9a69acf
Compare
|
@coderabbitai full review |
✅ Action performedFull review finished. |
9a69acf to
75b2dd9
Compare
This comment has been minimized.
This comment has been minimized.
✅ Action performedFull review finished. |
dd6751e to
e91ae5d
Compare
This comment has been minimized.
This comment has been minimized.
✅ Action performedFull review finished. |
e91ae5d to
3071793
Compare
cfc3117 to
b784884
Compare
# Conflicts: # src/renderer/src/i18n/locales/en.json
This comment has been minimized.
This comment has been minimized.
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
After merging main, the RPC probe and tooltip tests crossed their line limits. The missing-windows result reuses the Codex error-result helper, and the unlimited ProviderPanel test moves to its own file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ELI5
Codex Business accounts with unlimited usage can show “Refresh failed” because they have no percentage limits. This change shows “Codex · Business Unlimited” instead.
What Changed
Why
Missing percentage limits can also mean a failed response. Using Codex’s explicit unlimited flag avoids guessing from missing limits or a plan name, while keeping errors visible for accounts with limits.
Linked Issue
Fixes #15764
Visual Proof
Before — unlimited usage was treated as a refresh failure
After — the Business plan is shown as Unlimited
Testing
2026-10-14, macOS,
ORCA_BACKGROUND_LAUNCH=1. Mergedmainat5eda0a0dbdc0normally; HEAD5db26dfc26(#22001:703cd42b2c, identical source tree).pnpm typecheckand repository-wideoxlintfail only on a duplicatenowkey instructured-agent-session-message-options.ts. That file is unchanged here and fails the same way onmain(fix: a Claude model that's gone switches to the list's default when you send #27826, fix(native-chat): pass the clock to a recorded option pick #28571).Reproduce focused checks:
Screenshots are earlier feature evidence, not new captures. Not run: Bun tests, live account login, Linux/Windows/SSH, Electron builds, packaging, and full-repository lint/tests/build. GitHub workflows await maintainer approval (
action_required).AI Disclosure
OpenAI Codex (GPT-5.6, GPT-6 and GPT-6 Astra) was used to investigate, implement and test this change. Claude Opus 5.5 (
claude-opus-5-5) in Claude Code was used for the 2026-10-14 main merge, conflict resolution, line-limit fixes and validation; the diff and validation output were checked.Review
Agent skill upstream boundary
Notes
#15823 fixed app-server compatibility and #25408 added credit balances. This PR still handles unlimited-plan mapping, account caching and display through refresh errors.
Ensure no issues in: Security, Cross-platoform support (Linux, Windows, Mac), Remote SSH, Mobile, general backwards compatibility, performance
Author
X (Twitter): @hgijeon
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)🤖 Generated with Claude Code