Skip to content

Deprecate Gemini CLI setup while preserving existing sessions - #21682

Merged
nwparker merged 5 commits into
nwparker/agy-quota-commandfrom
nwparker/agy-legacy-setup
Sep 21, 2026
Merged

nwparker merged 5 commits into
nwparker/agy-quota-commandfrom
nwparker/agy-legacy-setup

Conversation

@nwparker

@nwparker nwparker commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 14 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1223 $\color{#cf222e}{\Huge{\mathbf{−}}}$​10 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1213
Prod 21 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​328 $\color{#cf222e}{\Huge{\mathbf{−}}}$​27 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​301

ELI5

Orca now recommends Antigravity for new Google CLI sessions and labels the older Gemini CLI integration as legacy. Existing Gemini sessions and explicit user choices remain usable.

What Changed

  • Agent pickers and Settings show Gemini CLI (legacy) and list Antigravity first.
  • Automatic selection prefers Antigravity when both Google CLIs are available. An explicit Gemini preference still wins; Gemini remains the fallback when agy is absent or disabled.
  • Accounts labels its Gemini section as legacy and explains that those credentials do not sign users into Antigravity. Search and setup documentation reflect that distinction.

Why

Deprecation should guide new setup while keeping old conversations accessible. The removal candidate #12789 deletes Gemini history/resume support and also removes Antigravity quota/preferences. This implementation keeps provider identities, saved settings, session readers, resume commands and remote contracts intact. Gemini model names returned by agy remain valid and are not renamed.

This is the setup-deprecation part of the migration. Antigravity Accounts sign-in and verified multi-account switching remain separate unfinished work.

Linked Issue

Refs #17345. Stacked on #21678.

Acknowledges @siddqamar’s original relevant contribution, as requested in #17345. This implementation is new; it does not copy the incompatible removal logic from #12789.

Visual Proof

Actual hidden Orca Accounts panel, before:
Before

After:
After

Actual Agents row after:
Legacy agent

The before Accounts capture used the parent component in the same hidden app, then restored the final source. Labels and ordering were inspected in the rendered Agents settings. No account switch or successful generation is implied by these screenshots.

Testing

  • I manually tested these changes locally
  • Automated tests added/updated

218 focused tests passed, including automatic selection, explicit Gemini choice, absent/disabled agy fallback, saved-session resume, catalog-order consistency, agent search, Agents settings and Accounts settings. Full pnpm tc, changed-code quality gate, localization-catalog verification and commit hooks passed. Docs site CI passed. Renderer changes validated through Electron CDP on macOS.

Installed agy 1.2.7 has been exercised throughout the parent stack for real launches, model discovery, task input, hooks registration and native /usage. Successful generation remains blocked by 401 ACCESS_TOKEN_TYPE_UNSUPPORTED. This copy/order change does not claim to fix authentication. Windows/Linux UI and a mixed-version paired deployment were not exercised live.

Review

The behavior is based on detected/enabled agents and existing saved preference selection. No credential migration or provider-ID rewrite. Folder workspaces and remote execution continue using the existing shared selection and resume paths; old hosts can still report Gemini identities.

Agent skill upstream boundary

  • Not applicable; no upstream skill source copied.

Notes

Legacy account controls remain available for existing users. This draft should not close the overall migration or multi-account issue. No component styling changed.

Checklist

  • This PR is small and focused
  • I explained the user-facing change, mechanism and reason
  • Before/after screenshots attached
  • Self-reviewed for correctness, security and performance
  • Cross-platform, SSH/remote and compatibility impact considered
  • Focused tests, full typecheck and changed-code quality passed; CI will cover remaining gates

@nwparker

Copy link
Copy Markdown
Contributor Author

CI follow-up: pushed 2ef3a1727a7 to regenerate the runtime-required English catalog. The earlier normal catalog sync was insufficient: CI has a separate boot-catalog coverage check, which reported five former call-site defaults that must now ship explicitly. Both verify:localization-catalog and verify:localization-runtime-catalog pass locally, as do commit hooks. Fresh CI is running.

@nwparker

nwparker commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor Author

Pushed a182628cd40 to update the orchestration skill-coverage test's expected Gemini label to Gemini CLI (legacy). CI shard 5 found the stale expectation; I reproduced it locally before changing it. All 17 tests in that file now pass, and commit hooks passed. No production behavior changed in this follow-up.

The preceding head passed static analysis (including both localization catalog gates), typecheck, Windows packaging, and the docs build. The corrected head now passes CI: run 35447141842 completed successfully, including all eight test shards, static analysis, typecheck, and both package jobs.

@nwparker

Copy link
Copy Markdown
Contributor Author

Independent verification (2026-09-20):

  • Targeted legacy/migration UI tests: 34/34 passed across Ai Vault legacy filtering, onboarding install targeting, manual agy command settings, native Chat support, and source-control settings.
  • pnpm tc:web passed.
  • pnpm run check:code-quality:changed origin/main passed with 0 new findings across 166 changed files.
  • Installed agy 1.2.7 authenticated exact sentinel returned AGY_LEGACY_OK.
  • Full CI run 35447141842 is green across all test shards, typecheck, static analysis, packages, and verify; docs build 35447141626 is green.

Verdict: approve in stack order for deprecating new Gemini setup while preserving existing Gemini sessions/settings. This does not remove legacy Gemini support or claim that agy remote/WSL setup is covered. No merge performed.

@nwparker

Copy link
Copy Markdown
Contributor Author

ELI5 / evidence / trade-offs audit

ELI5: New setup and labels point users toward Antigravity while existing Gemini sessions remain usable.

Proof: Full CI, docs build, migration UI tests, and authenticated agy sentinel pass; visual proof is covered by the stack's onboarding/settings evidence.

User-facing trade-off: Gemini is treated as legacy; remote/WSL setup is outside this evidence.

This note scopes the claim to the evidence above; it does not claim untested remote, SSH, WSL, or vendor combinations.

… startup (#21770)

* fix(antigravity): retain handoffs through slow Windows PTY binding

* fix(antigravity): show command approvals in Chat (#21776)

* fix(antigravity): publish captured command approvals to Chat

* fix(antigravity): bind native hook screen evidence to runtime terminal

* fix(antigravity): settle cancelled approvals at the idle composer

* fix(antigravity): clear approval while accepted commands run
@nwparker
nwparker marked this pull request as ready for review September 21, 2026 03:58
@pullfrog

pullfrog Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor
  • Checkout PR Deprecate Gemini CLI setup while preserving existing sessions #21682 and read full diff
  • Read existing summary snapshot and learnings
  • Triage: identify domains, seams, contracts
  • Dispatch reviewfrog specialists for unresolved questions
  • Aggregate findings and draft review
  • Update summary snapshot
  • Submit review via pullfrog_create_pull_request_review

Pullfrog  | View workflow run | via Pullfrog | Using DeepSeek Flash (free via Pullfrog for OSS) | 𝕏

@nwparker
nwparker merged commit 6988f3e into nwparker/agy-quota-command Sep 21, 2026
60 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant