-
Notifications
You must be signed in to change notification settings - Fork 5.1k
feat: Sleepy Mode — a resting screen for a fleet left running #21775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DannyHo15
wants to merge
9
commits into
stablyai:main
Choose a base branch
from
DannyHo15:feat/sleepy-mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
dc7fcdf
feat(sleepy-mode): resting screen for a fleet left running
63999d1
fix(sleepy-mode): raise the scene above tooltips, add an E2E
b6338f8
feat(sleepy-mode): give the scene an ambient background
3acd26b
feat(sleepy-mode): put the pet on the resting screen
a1e1f7a
chore(sleepy-mode): sync the runtime English catalog
78364c3
fix(sleepy-mode): trigger on the OS input clock, swallow the wake key
408bc83
test(sleepy-mode): dispatch the wake key at a real element
db33d96
Merge origin/main into feat/sleepy-mode
d871a3e
test(sleepy-mode): cover the pointer and scroll wake paths
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import { describe, expect, it } from 'vitest' | ||
| import { readSystemIdleSeconds } from './system-idle-seconds' | ||
|
|
||
| describe('readSystemIdleSeconds', () => { | ||
| it('passes through a reported idle time', () => { | ||
| expect(readSystemIdleSeconds({ getSystemIdleTime: () => 42 })).toBe(42) | ||
| expect(readSystemIdleSeconds({ getSystemIdleTime: () => 0 })).toBe(0) | ||
| }) | ||
|
|
||
| it('reports unknown rather than idle when the platform cannot measure it', () => { | ||
| expect(readSystemIdleSeconds({ getSystemIdleTime: () => Number.NaN })).toBeNull() | ||
| expect(readSystemIdleSeconds({ getSystemIdleTime: () => -1 })).toBeNull() | ||
| expect( | ||
| readSystemIdleSeconds({ | ||
| getSystemIdleTime: () => { | ||
| throw new Error('unsupported session type') | ||
| } | ||
| }) | ||
| ).toBeNull() | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import { powerMonitor } from 'electron' | ||
|
|
||
| type IdleMonitor = { | ||
| getSystemIdleTime: () => number | ||
| } | ||
|
|
||
| /** | ||
| * Seconds since the last OS-level input, or null when the platform cannot report it. | ||
| * | ||
| * Why the OS clock and not renderer events: browser panes are `<webview>`s in their own | ||
| * process and terminals/editors stop propagation, so renderer listeners miss real activity. | ||
| * Null (Wayland, or a throwing monitor) must read as "unknown", never as "idle". | ||
| */ | ||
| export function readSystemIdleSeconds(monitor: IdleMonitor = powerMonitor): number | null { | ||
| try { | ||
| const idle = monitor.getSystemIdleTime() | ||
| return Number.isFinite(idle) && idle >= 0 ? idle : null | ||
| } catch { | ||
| return null | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readSystemIdleSecondsrepeats theNumber.isFinite(idle) && idle >= 0guard already inreadDesktopAwayState(src/main/notifications/desktop-away-state.ts:15). Defer-able, but extracting a shared raw-seconds reader would keep the "unknown vs idle" rule in one place if more callers appear.