Repository navigation
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe Windows relay launch configuration now prepends Priority: ➖ Normal Severity of issue fixed: Medium 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Windows native-shell
Pathrepair —getRelayShellLaunchConfignow returns a case-insensitively patched path for PowerShell/PowerShell 7/cmd, prependingORCA_REMOTE_CLI_BIN_DIRand dropping a duplicate of that directory, instead of the previousenv: {}. - WSL and POSIX unchanged — the injection is gated to the same shell allowlist
windowsShellArgsalready uses, sowsl.exeand non-Windows platforms are untouched. - Tests — three new cases cover prepend, duplicate removal for
pwsh.exe/cmd.exe, and the WSL no-op; I confirmed the three PATH-injection cases fail against the baseenv: {}and pass with the change.
I dug into the case-collision root cause: buildSpawnEnv (src/relay/pty-handler.ts:786) can indeed hold both Path and PATH because the merge is a case-sensitive spread, but ConPTY passes the block through in object order and Win32 resolves the first case-insensitive match — exactly the key this function writes. The repo already encodes that rule in firstWindowsPathEnvKey (src/main/pty/windows-path-segment-merge.ts:18-28). I could not construct a realistic relay spawn that still loses the bridge directory.
ℹ️ Nitpicks
- The first-key lookup duplicates
firstWindowsPathEnvKey, whose comment states the same "first case-insensitive key, block order preserved" rule. ReusingresolvePathEnvKey(env, 'win32')fromsrc/main/pty/windows-path-segment-merge.tswould keep that assumption in one place. - The tests cover a single path key; the issue's stated trigger is a
Path/PATHcollision, so one case passing both keys would pin that the injected key is the one Win32 resolves.
DeepSeek Flash (free via Pullfrog for OSS) | 𝕏
|
SSH still works: Orca connects to the host over SSH and routes workspace operations through the managed remote Orca server (orcad). These merges remove the legacy SSH relay, not SSH support. Closing as obsolete after the merged SSH relay retirement in #27214 and #27215. This PR concerns the SSH relay server and its relay-only handlers. #27214 removed the desktop relay connection/fallback path; #27215 deleted the SSH relay server, deployment assets, and relay-only tests. SSH hosts now use the managed Orca server (orcad), and unsupported hosts fail explicitly, so this relay-specific work is no longer planned. This closes the proposed relay implementation; it does not claim that any independent local, WSL, or managed-server behavior was fixed. |
|
Thanks @abruption — the managed server (orcad) now provides the |

ELI5
Orca installs a small remote CLI bridge on SSH hosts. Native Windows terminals could receive the bridge location without seeing it in their effective
Path, so commands such asorca orchestration ...were unavailable inside the PTY. This makes the bridge discoverable in PowerShell and cmd while leaving WSL unchanged.What Changed
Before, the Windows relay returned no shell-specific environment adjustment. If inherited
PATHand client-providedPathcasing collided during the final environment merge, the native shell could loseORCA_REMOTE_CLI_BIN_DIR.Now, immediately before native Windows PTY spawn, the relay:
PATH/Pathkey case-insensitively;ORCA_REMOTE_CLI_BIN_DIR;Why
The relay is the last host-owned seam before ConPTY receives the environment, so it can repair the effective Windows path after all remote and inherited environment values have been combined. Doing this in POSIX startup wrappers would not cover native PowerShell or cmd and would incorrectly cross the WSL execution boundary.
Linked Issue
Fixes #22110
Visual Proof
N/A — this changes the native PTY environment and has no UI surface.
Testing
Validation:
pnpm test src/relay/pty-shell-launch.test.ts: 29 passedpnpm tc:node: passedmain: zero findingsgit diff --check: passedpwsh.exeThe same host blocked Orca's compressed bootstrap under stock Windows PowerShell 5.1 with an access-denied policy result before PTY launch. Unit coverage exercises the PowerShell 5.1 shell path; the successful end-to-end native PTY run used PowerShell 7.
AI Disclosure
OpenAI Codex (GPT-6) assisted with implementation and test preparation. I reviewed the change and ran the reported validation.
Review
The change is limited to the relay's native Windows shell launch environment and its focused tests. It does not alter POSIX shell wrappers, WSL arguments, the remote bridge installer, or wire contracts.
Agent skill upstream boundary
docs/reference/agent-skill-sharing-upstream-boundary.mdand copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.Notes
The added value is a fixed Orca-managed directory, not user-provided command text, and is passed through the process environment without a shell. PATH-key matching and duplicate removal are case-insensitive for Windows. macOS and Linux behavior is unchanged.
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)