-
Notifications
You must be signed in to change notification settings - Fork 5.1k
feat(orchestration): deliver worker results to a structured chat coordinator #22631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brennanb2025
wants to merge
26
commits into
brennanb2025/d3-cli-injection
Choose a base branch
from
brennanb2025/d4-coordinator-delivery
base: brennanb2025/d3-cli-injection
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
e217893
feat(orchestration): deliver worker results to a structured chat coor…
brennanb2025 3638aa0
test(orchestration): pin coordinator delivery through the real sessio…
brennanb2025 0727f57
test(orchestration): type the coordinator mail fixture's attach params
brennanb2025 72b0c73
fix(orchestration): refuse session recipients with the caller codes, …
brennanb2025 0e26182
fix(orchestration): wait out a pending worker preamble instead of dis…
brennanb2025 4dd65b3
test(orchestration): pin a chat's terminal view reading the chat's co…
brennanb2025 ad0f56c
test(orchestration): read coordinator mail fixtures through checked g…
brennanb2025 cbaf863
fix(orchestration): name a structured session's CLI by $ORCA_CLI_COMM…
brennanb2025 b1e6054
fix(orchestration): render the pointer's CLI invocation for the shell…
brennanb2025 e6f0d8e
fix(orchestration): address a session recipient where its check reads…
brennanb2025 e8d33aa
test(orchestration): pin the runtime's own idle-edge redrive wiring; …
brennanb2025 d71febe
fix(orchestration): point mail that has not been pointed, not mail no…
brennanb2025 feb42de
feat(orchestration): hand a /clear-replaced chat's Runs and unread ma…
brennanb2025 2c1c936
feat(orchestration): adopt a /clear predecessor's Runs at the clear's…
brennanb2025 2ddbd1b
fix(orchestration): log a wake that could not resume a session, inste…
brennanb2025 e3f0b36
test(orchestration): give coordinator mail waits a budget that holds …
brennanb2025 7b4c100
refactor(orchestration): narrow a retained pointer's dispatch state b…
brennanb2025 e4d53ae
fix(orchestration): give back a pointer whose admitted turn never ran
brennanb2025 a79ac15
fix(native-chat): keep a committed /clear from failing on its replace…
brennanb2025 9e31f3a
test(orchestration): pin /clear adoption across a chain of clears and…
brennanb2025 737ceed
test(orchestration): type the pending-settlement host test's send inp…
brennanb2025 d7a4fb7
fix(orchestration): keep a chat's orchestration address across /clear…
brennanb2025 d42487e
fix(orchestration): give back a structured pointer claim an earlier p…
brennanb2025 bdc92d7
test(orchestration): pin that a cleared chat's sends carry its conver…
brennanb2025 36d32dd
fix(orchestration): open the orchestration database at an idle edge o…
brennanb2025 92ecd41
fix(orchestration): read a chat-coordinated Run's session through the…
brennanb2025 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Codex arm is now correct, but the
win32+claudefall-through still hardcodes the POSIX form on the premise that Claude on Windows always runs commands in Git Bash. Upstream Claude Code docs say Git Bash is optional: the PowerShell tool is primary when enabled, and PowerShell is the only shell when Git for Windows is absent — there"$ORCA_CLI_COMMAND"is a PowerShell parse error and the pointer turn cannot runcheck.Orca already makes this exact distinction for Claude hooks:
getWindowsManagedLifecycleHook(src/main/claude/hook-settings.ts:180-192) uses the direct POSIX command only whenisGitBashAvailable(), otherwise it emits a PowerShell command. The pointer lane should branch the same way, or the JSDoc atcli-command.ts:18should state the Git Bash precondition so the assumption is auditable.Technical details