Skip to content

test(mobile): repin the RPC recording corpus and session closure after #22392 - #22702

Merged
Jinwoo-H merged 2 commits into
mainfrom
repin-rpc-recording-after-22392
Sep 24, 2026
Merged

Jinwoo-H merged 2 commits into
mainfrom
repin-rpc-recording-after-22392

Conversation

@Jinwoo-H

@Jinwoo-H Jinwoo-H commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​12 $\color{#cf222e}{\Huge{\mathbf{−}}}$​4 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​8
Prod 788 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​788 $\color{#cf222e}{\Huge{\mathbf{−}}}$​788 0

ELI5

Main's CI is red for every open PR. Two test pins were wrong after #22392 landed; this puts both back in line with main. There is no product change.

What Changed

Why

Repinning to main's tip is the only baseline that is both reachable and recordable (the product sources match it exactly). Re-recording the full corpus proves the pin change is provenance-only.

Linked Issue

N/A: CI unblocker for #22392's squash.

Visual Proof

N/A: test pins only, no UI or behaviour change.

Testing

  • rpc-recording-pin-guard.mts ancestry and reproduce: pass (reproduce: 791 tests from the pinned tree).

  • Recording suites replayed against the corpus: 1752 passed.

  • rpc-recording-pin-guard.test.ts: 19 passed.

  • config/scripts closure suites (session-terminal closure, page-closure families, bundle build): 77 passed.

  • I manually tested these changes locally

  • Automated tests added/updated, or explained why not below

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • N/A for visual proof with reason
  • Self-reviewed
  • Cross-platform, SSH/remote impact: N/A (test pins only)

#22392 pinned baseline to a branch commit (2c2b84c) that the squash left
unreachable, so the recording-pin ancestry job failed on main and every PR.
Repin to main's tip 80e0bee and re-record the whole corpus: all 787
goldens change only their baseline header, so no recorded behaviour moved.
Main reads 4219, not 4217: #22301 added two src/shared modules to the route
without touching mobile/, so main was already two over when #22392 measured
its -2 against a branch base that lacked them.
@pullfrog

pullfrog Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

This run was cancelled 🛑

The workflow was cancelled before completion. Please check the link below for details.

Pullfrog  | View workflow run | via Pullfrog | 𝕏

@Jinwoo-H
Jinwoo-H merged commit 9f7f406 into main Sep 24, 2026
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant