test(mobile): repin the RPC recording corpus and session closure after #22392 - #22702
Merged
Merged
Conversation
Contributor
|
This run was cancelled 🛑 The workflow was cancelled before completion. Please check the link below for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

ELI5
Main's CI is red for every open PR. Two test pins were wrong after #22392 landed; this puts both back in line with main. There is no product change.
What Changed
baselineset to one of its own branch commits (2c2b84ce9e). The squash merge left that commit unreachable from main, so the "RPC recording pin" ancestry job fails everywhere. This setsbaselineto main's tip at the time (80e0bee23b) and re-records the whole corpus. All 787 goldens change only theirbaselineheader line, so no recorded behaviour moved.SESSION_ROUTE_MODULESsaid 4217; main measures 4219. feat(native-chat): show context window usage in the composer #22301 added twosrc/sharedmodules (agent-session-context-usage.ts,agent-session-context-usage-schema.ts) to the session route without touchingmobile/, so the mobile job never ran and main was already two over (4221) when fix(mobile): keep the streamed browser pane flipping on slow phones, and stop double taps #22392 took its correct -2 from a branch base that lacked them. Measured 4219 at25d7c21fcb^, 4221 at25d7c21fcb, 4221 before fix(mobile): keep the streamed browser pane flipping on slow phones, and stop double taps #22392, 4219 on main's tip. The pin is set to the measured value, with a history paragraph naming feat(native-chat): show context window usage in the composer #22301.Why
Repinning to main's tip is the only baseline that is both reachable and recordable (the product sources match it exactly). Re-recording the full corpus proves the pin change is provenance-only.
Linked Issue
N/A: CI unblocker for #22392's squash.
Visual Proof
N/A: test pins only, no UI or behaviour change.
Testing
rpc-recording-pin-guard.mts ancestryandreproduce: pass (reproduce: 791 tests from the pinned tree).Recording suites replayed against the corpus: 1752 passed.
rpc-recording-pin-guard.test.ts: 19 passed.config/scriptsclosure suites (session-terminal closure, page-closure families, bundle build): 77 passed.I manually tested these changes locally
Automated tests added/updated, or explained why not below
Checklist
N/Afor visual proof with reason