[OrcaWin]

	Files	Added	Deleted	Net
Test	0	0	0	0
Prod	1	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​2	$\color{#cf222e}{\Huge{\mathbf{−}}}$​2	0

ELI5

Mobile builds were blocked by a shared command helper claiming its environment map always contained Expo's required NODE_ENV field. The helper now declares the map it actually accepts and returns.

What Changed

Change the input and return annotations of mergeCommandEnvironment from NodeJS.ProcessEnv to Record<string, string | undefined>. There is no executable-code change. Desktop keeps its existing environment merge behavior, including case-insensitive Windows keys, and the mobile typecheck succeeds.

Why

Expo augments NodeJS.ProcessEnv with a required NODE_ENV field. A command-specific environment is an arbitrary map and does not promise that field. Using the map's real type avoids a cast or fabricating NODE_ENV, either of which would obscure the contract or change command behavior.

Linked Issue

Follow-up to #22427, exposed by the refreshed #22279 mobile check.

Visual Proof

N/A — type annotations only.

Testing

• Mobile typecheck reproduced TS2741 before the change and passes after refreshing installed dependencies to the frozen lockfile.
• Node typecheck passes; existing command-environment suite passes 5 tests, including Windows key folding and unchanged-base behavior.
• Changed-code quality, focused lint, formatting and whitespace checks pass on macOS.
• Manual app test; unnecessary for erased type annotations.

Review

One file, two type annotations. No casts, new dependency, environment value or runtime behavior.

Agent skill upstream boundary

• Not applicable.

Notes

Cross-platform, SSH and folder-workspace runtime behavior is unchanged. No wire change.

Checklist

• Small, focused change with mechanism and alternatives explained.
• Relevant tests, typechecks and quality checks passed.
• Self-reviewed for platform and compatibility impact.

[pullfrog]

✅ No new issues found.

Reviewed changes

• Command environment types — mergeCommandEnvironment now declares base and its return as Record<string, string | undefined> instead of NodeJS.ProcessEnv, avoiding Expo's required NODE_ENV augmentation while keeping desktop behavior identical.

The change is type-only, correctly matches the implementation (which returns base or an Object.fromEntries map), and loosens rather than asserts. Verified pnpm tc:node passes and src/shared/command-environment.test.ts passes all 5 tests, including Windows key folding and the unchanged-base case.

  ^{｜ View workflow run ｜ Using DeepSeek Flash (free via Pullfrog for OSS) ｜ 𝕏}