Repository navigation
Conversation
Collaborator
|
Closing as superseded: desktop builds now ship the managed server template through #24155, so this preparation branch is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Main now has Bun-backed Orca and SQLite profile storage. The old convergence PR cannot safely replace those implementations. This draft starts the rebuild from main at
46907de6022, retaining its Bun 1.4.2 and storage behavior.Preparation only. Not a merge-ready replacement for #16741.
What Changed
There is no new user-facing SSH workflow yet. Managed deployment targets remain POSIX-only; packaging a template in a Windows desktop does not add managed Windows-host support.
Why
A trial replay of #16741 produced 109 conflicts. More importantly, restoring its old startup and persistence code would discard main's SQLite authority and final-flush protections, while its older Bun code would replace newer native terminal fixes.
This preserves main's implementation and prepares its existing deployment payload for the remaining convergence work instead of reviving duplicate runtime code. Main intentionally omitted this unused payload; do not merge this draft until the deployment consumer is wired. The locally generated template is approximately 102 MB before compression.
Linked Issue
Continuation of #16741 after #22635. The old branch/head
a68b6f35311012846a423654cee72866567b14cdremains untouched and preserves the full implementation.Remaining before readiness
No claim of universal lossless migration or completion of SSH/Remote unification.
Visual Proof
N/A — build and packaging preparation only; no UI changes.
Testing
pnpm install --frozen-lockfile: passed.pnpm tc: passed.Tests used background-launch and mock-keychain flags. No installer was produced, no user host was upgraded, and no live migration or Windows/Linux hardware matrix was executed.
Review
Two independent audits identified runtime/storage overlap and the remaining SSH ownership requirements. Main's runtime implementation, terminal backend, deployment transactions, lockfile, and persistence implementation are unchanged in this draft.
Agent skill upstream boundary
Checklist