test(claude): fix queued-send cancellation CI expectations

[nwparker]

	Files	Added	Deleted	Net
Test	3	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​6	$\color{#cf222e}{\Huge{\mathbf{−}}}$​3	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​3
Prod	0	0	0	0

ELI5

Unrelated pull requests were failing five Claude cancellation tests after recent changes merged. Update the tests to check the complete cancellation result so CI can pass again.

What Changed

Add the expected rejection: { kind: 'cancelled' } to the queued-send cancellation assertions, including the real-Claude check. Exact equality and the checks that only withdrawn messages settle remain intact. Application behavior is unchanged.

Why

The cancellation result intentionally gained a typed reason in #23116, but #23553 introduced expectations without it. Checking that field preserves the contract; dropping it from production or weakening the assertions would hide regressions.

Linked Issue

CI failures: https://github.com/stablyai/orca/actions/runs/36469406876 and https://github.com/stablyai/orca/actions/runs/36468659066.

Visual Proof

N/A — test expectations only.

Testing

• Reproduced the five failing tests locally before the change.
• All 31 targeted unit tests pass locally on macOS; full typecheck and changed-code quality checks pass.
• The real-Claude cancellation check passes. Another local real-CLI test fails on project command catalog discovery; the complete CI suite will verify the fix.

Review

Self-reviewed: this adds an expected field without relaxing existing assertions.

Agent skill upstream boundary

• Not applicable.

Notes

No platform, SSH, folder-workspace, or wire behavior changes.

Checklist

• This PR is small and focused
• I explained what changed and why
• N/A with reason for visual proof
• Self-reviewed for correctness, security, and performance
• Cross-platform and SSH/remote impact considered
• Full validation in CI

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 5012fe58-09dd-4014-b135-9aa8d0eaf2bd

📥 Commits

Reviewing files that changed from the base of the PR and between 3eac4d9 and 81748e5.

📒 Files selected for processing (3)

• src/main/claude/claude-structured-control-actions.test.ts
• src/main/claude/claude-structured-queued-stop.test.ts
• src/main/claude/claude-structured-real-cli.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

Three cancellation test expectations now include rejection: { kind: 'cancelled' } alongside the existing rejection state or cancellation reason.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 81748

The application behavior is unchanged, and the tests now expect the structured cancellation result the producer emits. No merge-blocking risk is evident; normal CI checks remain appropriate.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: updating Claude queued-send cancellation test expectations.
Description check	✅ Passed	The description is mostly complete. It explains the change, reason, testing, scope, and validation status. The Linked Issue section lists CI run links instead of an issue reference, and full CI valida…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[pullfrog]

✅ No new issues found.

Reviewed changes

• claude-structured-control-actions.test.ts — adds rejection: { kind: 'cancelled' } to the settled.mock.calls exact-equality assertion so it matches the full settlement production emits.
• claude-structured-queued-stop.test.ts — adds the field to the shared WITHDRAWN constant that four tests compare against with toEqual.
• claude-structured-real-cli.test.ts — adds the field to the toContainEqual assertion on the real-CLI settlement.

The additions match production exactly: settleCancelledClaudeDispatchWaiters builds each settlement through claudeDispatchRejection(agentSessionFailureFact('cancelled')), which returns both the legacy marker reason and the typed rejection fact { kind: 'cancelled' }. The assertions remain exact-equality and are tightened, not relaxed. I ran the three changed suites (31/31 pass) plus the other suites touching this contract (194/194 pass), and the remaining cancellation assertions either use toMatchObject or already carry the field.

  ^{｜ View workflow run ｜ Using DeepSeek Flash (free via Pullfrog for OSS) ｜ 𝕏}