Repository navigation
Conversation
Collaborator
Author
|
Closing as defunct: Orca stays on Node outside Electron, and the bundled-Bun runtime migration this stack belongs to was wound down. Servers and remote hosts now run on the bundled Node 24 runtime (#26171). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Windows SSH terminals need the same console implementation as desktop terminals. Shipping a patched Bun executable alone is insufficient: without the provider files and startup selection, SSH terminals still use the Windows default and retain the observed wide-character resize loss.
What Changed
Windows relay packages now contain the existing pinned ConPTY DLL, OpenConsole executable, license and provenance. All five files participate in the existing relay content hash and completeness checks. The SSH launcher selects the adjacent DLL before starting Bun; the relay verifies both binary hashes and checks that the selector belongs to its installation before starting terminals.
The release watcher fault test now launches both relay processes with the verified bundled CLI Bun runtime. It keeps Node as its test runner, verifies the Windows provider before launch, and checks both packaged provider architectures after signing.
Reconnect and CLI bridge modes do not create terminals and remain independent of this check. POSIX relay artifacts retain their existing order and content. Existing live relay generations are not overwritten.
Why
This reuses the existing provider materializer, hash verification and immutable relay deployment instead of adding a separate download or native launcher. Selecting the provider inside an already running Bun process would be too late for its native startup environment.
Linked Issue
Stacked on #23741 and the Bun consolidation work in #23622. No separate issue.
Visual Proof
N/A — packaging and daemon admission. Native SSH resize evidence is a required remaining draft gate, not yet claimed by this PR.
Testing
2084c58ba5: relay and existing terminal survived watcher termination; replacement watcher delivered recovery and new events; recorded PIDs exited. Windows/Linux execution remains open.2084c58ba5with no P0/P1/P2 findings and independently reran 31 tests; final platform CI remains open.Review
Missing, corrupt, wrong-architecture or foreign provider selections fail before terminal creation. Existing cancellable upload, complete-marker and generation-retention mechanisms carry the new files.
Agent skill upstream boundary
Notes
Draft: do not merge independently of the qualified runtime. This PR does not change the Bun pin. The current stock binary does not consume the provider selector; JavaScript admission cannot prove otherwise. The patched runtime plus provider passed the separate x64/ARM64 artifact matrix, but final stable-mode binaries and this actual SSH route must still be qualified together.
No tracking, design or measurement documents are included. No merge or runtime promotion is requested.
Checklist