Repository navigation
fix(github): enqueue a merge-queue PR when auto-merge is disabled #24327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
innocarpe
wants to merge
5
commits into
stablyai:main
Choose a base branch
from
innocarpe:fix-19638-merge-queue-enqueue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0325f32
fix(github): enqueue a merge-queue PR when auto-merge is disabled
innocarpe 7eaad3d
fix(github): show a merge-queue enqueue as queued, not auto-merged
innocarpe 90234c7
fix(github): keep an enqueue result assignable to the success toast
innocarpe febd87e
fix(github): confirm a merge-queue enqueue as queued, not auto-merge
innocarpe 21bc876
fix(github): accept the merge-queue entity on the mutation runner
innocarpe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
src/main/github/client/lookup/pull-request-merge-queue-membership.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import { ghExecFileAsync } from '../../gh-utils' | ||
| import { githubHostExecOptions, type GitHubApiRepository } from '../../github-api-repository' | ||
| import { noteRepositoryRateLimitSpend, repositoryRateLimitGuard } from '../../rate-limit' | ||
| import type { GhExecOptions } from '../github-exec-scope' | ||
|
|
||
| /** True when this pull request already has a merge-queue entry. | ||
| * `gh pr view` has no field for that, and enqueue does not set autoMergeRequest. */ | ||
| export async function readPullRequestInMergeQueue( | ||
| ownerRepo: GitHubApiRepository, | ||
| prNumber: number, | ||
| ghOptions: GhExecOptions | ||
| ): Promise<boolean | undefined> { | ||
| const guard = repositoryRateLimitGuard(ownerRepo, 'graphql', ghOptions) | ||
| if (guard.blocked) { | ||
| return undefined | ||
| } | ||
| const query = `query($owner: String!, $repo: String!, $number: Int!) { | ||
| repository(owner: $owner, name: $repo) { | ||
| pullRequest(number: $number) { isInMergeQueue } | ||
| } | ||
| }` | ||
| try { | ||
| noteRepositoryRateLimitSpend(ownerRepo, 'graphql', 1, ghOptions) | ||
| const { stdout } = await ghExecFileAsync( | ||
| [ | ||
| 'api', | ||
| 'graphql', | ||
| '-f', | ||
| `query=${query}`, | ||
| '-f', | ||
| `owner=${ownerRepo.owner}`, | ||
| '-f', | ||
| `repo=${ownerRepo.repo}`, | ||
| '-F', | ||
| `number=${prNumber}` | ||
| ], | ||
| { ...ghOptions, ...githubHostExecOptions(ownerRepo) } | ||
| ) | ||
| const parsed = JSON.parse(stdout) as { | ||
| data?: { repository?: { pullRequest?: { isInMergeQueue?: unknown } | null } | null } | ||
| } | ||
| const value = parsed.data?.repository?.pullRequest?.isInMergeQueue | ||
| return typeof value === 'boolean' ? value : undefined | ||
| } catch { | ||
| return undefined | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
src/renderer/src/components/github-auto-merge-success-toast.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import { translate } from '@/i18n/i18n' | ||
| import type { GitHubPRMergeStatePresentation } from './github-pr-merge-state' | ||
|
|
||
| export function githubAutoMergeSuccessToast( | ||
| enabled: boolean, | ||
| result: { enqueued?: boolean } | void | null | ||
| ): string { | ||
| if (!enabled) { | ||
| return translate('auto.components.PullRequestPage.0f5821b035', 'Auto-merge disabled') | ||
| } | ||
| if (result && result.enqueued === true) { | ||
| return translate( | ||
| 'auto.components.PullRequestPage.mergeQueueEnqueued', | ||
| 'Added to the merge queue' | ||
| ) | ||
| } | ||
| return translate('auto.components.PullRequestPage.5edbe7eefa', 'Auto-merge enabled') | ||
| } | ||
|
|
||
| export function presentPullRequestInMergeQueue(tone: string): GitHubPRMergeStatePresentation { | ||
| return { | ||
| label: translate('auto.components.github.pr.merge.state.inMergeQueue', 'In merge queue'), | ||
| tone, | ||
| tooltip: translate( | ||
| 'auto.components.github.pr.merge.state.inMergeQueueTooltip', | ||
| 'This pull request is already in the GitHub merge queue' | ||
| ), | ||
| directMergeAvailable: false, | ||
| autoMergeAction: null | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.