Repository navigation
fix(terminal): encode Ctrl+C when the kitty keyboard protocol is on #24370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
innocarpe
wants to merge
8
commits into
stablyai:main
Choose a base branch
from
innocarpe:fix-17665-kitty-interrupt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+519
−100
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9502875
fix(terminal): encode Ctrl+C when kitty keyboard mode is on
innocarpe 8fac3b3
fix(terminal): keep kitty interrupt mode across a replaced headless m…
innocarpe 73db700
fix(terminal): send ETX when kitty mode only reports alternate keys
innocarpe 3c1a0f3
fix(terminal): reapply kitty flags when a renderer buffer seeds the m…
innocarpe c3b9dfa
fix(terminal): apply kitty flags from an empty renderer buffer
innocarpe 2bdf198
fix(terminal): route renderer Ctrl+C through kitty-aware encoder
innocarpe 0749f54
fix(terminal): track kitty Ctrl+C input intent
innocarpe 17d74ca
fix(terminal): recognize Kitty Ctrl+C in downstream input
innocarpe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import { describe, expect, it } from 'vitest' | ||
| import { HeadlessEmulator } from './headless-emulator' | ||
|
|
||
| describe('HeadlessEmulator kitty keyboard flags', () => { | ||
| it('stays at zero until the PTY pushes the protocol', async () => { | ||
| const emulator = new HeadlessEmulator({ cols: 80, rows: 24 }) | ||
|
|
||
| expect(emulator.kittyKeyboardFlags()).toBe(0) | ||
| await emulator.applyKittyKeyboardFlags(1) | ||
|
|
||
| expect(emulator.kittyKeyboardFlags()).toBe(1) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { describe, expect, it } from 'vitest' | ||
| import { TERMINAL_INTERRUPT_KITTY_CTRL_C } from '../../shared/terminal-interrupt-bytes' | ||
| import { RuntimeTerminalWriter } from './runtime-terminal-writer' | ||
|
|
||
| describe('RuntimeTerminalWriter interrupt bytes', () => { | ||
| it('writes a bare ETX when the PTY has no kitty keyboard flags', async () => { | ||
| const writes: string[] = [] | ||
| const writer = new RuntimeTerminalWriter((ptyId, data) => { | ||
| expect(ptyId).toBe('pty-1') | ||
| writes.push(data) | ||
| return true | ||
| }) | ||
|
|
||
| await writer.writeAction('pty-1', { interrupt: true }, '\x03', { inputKind: 'driving' }) | ||
|
|
||
| expect(writes).toEqual(['\x03']) | ||
| }) | ||
|
|
||
| it('writes the interrupt bytes already chosen for the payload', async () => { | ||
| const writes: string[] = [] | ||
| const writer = new RuntimeTerminalWriter((_ptyId, data) => { | ||
| writes.push(data) | ||
| return true | ||
| }) | ||
|
|
||
| await writer.writeAction('pty-1', { interrupt: true }, TERMINAL_INTERRUPT_KITTY_CTRL_C, { | ||
| inputKind: 'driving' | ||
| }) | ||
|
|
||
| expect(writes).toEqual([TERMINAL_INTERRUPT_KITTY_CTRL_C]) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.