fix(native-chat): restore main typecheck after #24312 and #24334 crossed

[Jinwoo-H]

	Files	Added	Deleted	Net
Test	3	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​18	$\color{#cf222e}{\Huge{\mathbf{−}}}$​7	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​11
Prod	1	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​6	$\color{#cf222e}{\Huge{\mathbf{−}}}$​1	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​5

ELI5

Two native-chat changes merged close together and each passed on its own, but together main stopped typechecking. This updates the newer one to use the other's reporting mechanism.

What Changed

#24312 replaced the optional onEventSinkError callback on the structured chat host with a required diagnostics logger. #24334, merged right after, still reported a failed "end the Codex process on Stop" through onEventSinkError, and its new tests built hosts without a logger.

• structured-agent-session-chat-stop.ts: the failed child end is now written through context.deps.logger.warn (scope stop-child, with the session id and error), so it lands in the same diagnostics log as every other host failure.
• structured-agent-session-conversation-stop.test.ts: asserts a stop-child entry for the session through a recording logger instead of the removed callback.
• structured-agent-session-repeat-press.test.ts, structured-agent-session-repeated-stop.test.ts: pass the now-required logger.

No user-visible behavior changes: Stop handling is untouched, only where its failure is reported.

Why

Smallest change that makes main typecheck while keeping #24334's failure reporting, routed through #24312's single required logger.

Linked Issue

N/A (main build fix, maintainer)

Visual Proof

N/A: typecheck fix, no UI change.

Testing

• pnpm tc passes.

• pnpm test src/main/native-chat/agent-session-wire: 152 files, 1284 tests pass.

• oxlint on touched files and pnpm run check:code-quality:changed pass.

• I manually tested these changes locally

• Automated tests added/updated, or explained why not below

Agent skill upstream boundary

• Not applicable

Checklist

• This PR is small and focused
• I explained what changed and why
• N/A for visual proof with reason
• Self-reviewed for correctness, security, and performance
• Cross-platform, SSH/remote impact considered (N/A)

[greptile-apps]

Confidence Score: 4/5

[Medium risk] Fixes type errors in chat session stop handling.

The PR appears safe to merge, though the Stop-child diagnostic tests should verify the error they are intended to preserve.

Findings

1.  Stop error goes unchecked ▶

Summary

The PR routes failed Stop-child termination reports through the required host diagnostics logger and updates three test files to supply or inspect that logger.

• The production reporting path matches the logger contract.
• The updated failure-reporting assertions do not verify that the caught error is retained.

_{Reviews (1) · Last reviewed commit: "fix(native-chat): report a failed Stop c..."}

[greptile-apps]

Stop error goes unchecked The two new assertions check only the log scope and session ID. They would still pass if the Stop-child warning stopped including the caught error, leaving the failure detail this change is meant to preserve untested. The recording logger retains the warning level and error field; please assert those for both cases, especially the case that throws route release failed.