Repository navigation
Conversation
nwparker
marked this pull request as ready for review
October 2, 2026 08:49
Contributor
Author
|
Superseded by the test typing/property fix that has now landed on main in b49abdb (#24250). I inspected the exact current-main test: the broad object callback and both Reflect.get calls are gone, and the stubbed delay has a typed global declaration. The standalone fix here also passed the existing regression and exact anti-slop gate independently, but is now redundant. Closing this PR; integration PRs will rebase onto current main rather than wait for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
The same unchanged unit test blocks several integration PRs because it uses three patterns rejected by CI. Give its mock the real Playwright type and read the checked delay property directly.
What Changed
Only
terminal-pty-write-spy.unit.test.ts: useElectronApplication['evaluate']for the mock, pass the imported Electron module to function callbacks, and check the stubbed global exists before typed property reads. The test still executes the callback with evaluate’s second argument and proves delay changes from 35 to 0.Why
#24572, #24575, and #24584 all fail the same anti-slop gate on main’s broad
objectcallback and twoReflect.getcalls. This fixes the test boundary without changing the runtime helper, weakening the assertions, adding casts, or suppressing lint.Linked Issue
Shared CI blocker observed in #24572, #24575, and #24584; no issue closure requested.
Visual Proof
N/A — pure unit-test typing/property access; no UI or runtime behavior changes.
Testing
ORCA_BACKGROUND_LAUNCH=1 pnpm test tests/e2e/helpers/terminal-pty-write-spy.unit.test.ts, exactpnpm run audit:anti-slop, and changed-code quality pass.pnpm typecheck:e2ereports 222 existing errors; its full diagnostics are byte-identical against unmodified main53930a161be4dd4420e9c71be0dadac6e9388752, with no errors in this test.Review
Self-reviewed the single-file diff: both delay assertions still depend on the callback’s second argument. Runtime helper unchanged; no casts, broad object/any declarations, reflection, or lint suppressions added.
Agent skill upstream boundary
Notes
No platform, SSH, folder workspace, wire, or production execution change. No app, auth, or global configuration changes. Antigravity draft #24627 remains separate and unchanged.
Checklist