Skip to content

test(runtime): add main's getTitleDisplayClear to the mobile incarnation projection stub - #24953

Closed
OrcaWin wants to merge 1 commit into
OrcaWin/node-rt-phase3from
OrcaWin/node-rt-p3-mobile-incarnation-fix
Closed

OrcaWin wants to merge 1 commit into
OrcaWin/node-rt-phase3from
OrcaWin/node-rt-p3-mobile-incarnation-fix

Conversation

@OrcaWin

@OrcaWin OrcaWin commented Oct 3, 2026 •

Copy link
Copy Markdown
Collaborator
Files Added Deleted Net
Test 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1 0 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1
Prod 0 0 0 0

ELI5

A test broke when main was merged into the integration branch. The feature it protects is intact. The test's fake object was just missing a method that main started calling, so the test now provides it.

What Changed

Cause:

Is the fix still there? Yes:

Change: the stub gains getTitleDisplayClear: () => null, meaning no title clear is recorded. That's the neutral answer for this test, which is about incarnations, not titles.

Why

This is fixture drift, not a regression. Re-applying the projection change would have been a no-op.

Linked Issue

Fixes # (none: maintainer fix for the Phase 3 integration branch after a main merge)

Visual Proof

N/A: test fixture only.

Testing

  • The incarnation projection test passes: 4 of 4.

  • Mutation check: removing the incarnationId line from the projection makes it fail 2 of 4 again, so it still guards the fix.

  • 30 mobile session and remote-runtime transport test files pass (214 tests).

  • Scoped tsc (with declarations), oxlint, oxfmt and the changed-code quality gate pass. The lockfile is unchanged.

  • I manually tested these changes locally

  • Automated tests added/updated, or explained why not below

Notes

Test-only change. No product, cross-platform, SSH or mobile behaviour changes.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • N/A for visuals with reason
  • Self-reviewed for correctness, security, and performance
  • Cross-platform, SSH/remote impact considered
  • pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (CI will cover; targeted local runs listed above)

…r host member

main's #24295 added getTitleDisplayClear to the mobile projection host and calls it for
every terminal tab; the #24413 test stub predates it. The incarnation projection itself is
intact on the merged code (removing it fails the test).

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Add missing host stub member — runtime-mobile-session-incarnation-projection.test.ts gains getTitleDisplayClear: () => null, restoring the stub to parity with RuntimeMobileSessionProjectionHost after main's #24295 started calling the method (runtime-mobile-session-projection.ts:152,154,209). This is fixture drift from the merge, not a regression; null is the neutral "no title clear" answer this incarnation-focused test does not depend on.

I ran the file: 4/4 pass. The stub is cast as unknown as RuntimeMobileSessionProjectionHost, so it typechecked even while missing the member — the failure was runtime-only, which matches the described TypeError.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

@OrcaWin

OrcaWin commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #24887, which carries the identical getTitleDisplayClear stub fix and is merged into OrcaWin/node-rt-phase3.

@OrcaWin OrcaWin closed this Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant