Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Add missing host stub member —
runtime-mobile-session-incarnation-projection.test.tsgainsgetTitleDisplayClear: () => null, restoring the stub to parity withRuntimeMobileSessionProjectionHostaftermain's #24295 started calling the method (runtime-mobile-session-projection.ts:152,154,209). This is fixture drift from the merge, not a regression;nullis the neutral "no title clear" answer this incarnation-focused test does not depend on.
I ran the file: 4/4 pass. The stub is cast as unknown as RuntimeMobileSessionProjectionHost, so it typechecked even while missing the member — the failure was runtime-only, which matches the described TypeError.
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏
Collaborator
Author
|
Superseded by #24887, which carries the identical getTitleDisplayClear stub fix and is merged into OrcaWin/node-rt-phase3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

ELI5
A test broke when
mainwas merged into the integration branch. The feature it protects is intact. The test's fake object was just missing a method thatmainstarted calling, so the test now provides it.What Changed
Cause:
main's fix(runtime): make OMP 18.4 workers ready at the composer and keep stale-title clears display-only #24295 (OMP 18.4 workers and display-only stale-title clears) addedgetTitleDisplayClear(ptyId)toRuntimeMobileSessionProjectionHost.projectRuntimeMobileSessionTabsnow calls it for every terminal tab.runtime-mobile-session-incarnation-projection.test.tscomes from fix(runtime): project the PTY incarnation onto mobile session tabs #24413, before fix(runtime): make OMP 18.4 workers ready at the composer and keep stale-title clears display-only #24295, and didn't have that method. All four cases threwTypeError: host.getTitleDisplayClear is not a function.Is the fix still there? Yes:
mainitself doesn't have fix(runtime): project the PTY incarnation onto mobile session tabs #24413 any more: the Phase 3 revert (revert: take the 26 Phase 3 (#16741 port) PRs back out of main #24559) removed it there.mainmerge,OrcaWin/node-rt-phase3still has it:runtime-mobile-session-projection.tspublishesterminalPty.incarnationId, the incarnation of the PTY that owns the issued handle.Change: the stub gains
getTitleDisplayClear: () => null, meaning no title clear is recorded. That's the neutral answer for this test, which is about incarnations, not titles.Why
This is fixture drift, not a regression. Re-applying the projection change would have been a no-op.
Linked Issue
Fixes # (none: maintainer fix for the Phase 3 integration branch after a main merge)
Visual Proof
N/A: test fixture only.
Testing
The incarnation projection test passes: 4 of 4.
Mutation check: removing the
incarnationIdline from the projection makes it fail 2 of 4 again, so it still guards the fix.30 mobile session and remote-runtime transport test files pass (214 tests).
Scoped tsc (with declarations), oxlint, oxfmt and the changed-code quality gate pass. The lockfile is unchanged.
I manually tested these changes locally
Automated tests added/updated, or explained why not below
Notes
Test-only change. No product, cross-platform, SSH or mobile behaviour changes.
Checklist
N/Afor visuals with reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (CI will cover; targeted local runs listed above)