Skip to content

test(native-chat): a mirrored paired chat carries its host, so a workspace-id collision no longer hides its owner #25079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brennanb2025 wants to merge 1 commit into from
Closed

test(native-chat): a mirrored paired chat carries its host, so a workspace-id collision no longer hides its owner #25079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/renderer/src/components/native-chat/StructuredAgentSessionAttentionBridge.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,8 @@ describe('StructuredAgentSessionAttentionBridge', () => {
throw new Error('snapshot did not publish a chat tab')
}
expect(tab.contentType).toBe('agent-session')
expect(tab.executionHostId).toBeUndefined()
// The snapshot stamps each mirrored chat with its host, so a later id collision cannot reassign it.
expect(tab.executionHostId).toBe('runtime:env-1')
render(<StructuredAgentSessionAttentionBridge />)
await waitFor(() => expect(mocks.subscribeCompletions).toHaveBeenCalledOnce())
expect(mocks.subscribeCompletions.mock.calls[0]?.[0]).toEqual({
Expand All @@ -470,7 +471,10 @@ describe('StructuredAgentSessionAttentionBridge', () => {
}
})
)
expect(resolveNotificationTabOwner(store.getState(), tab)).toBeNull()
expect(resolveNotificationTabOwner(store.getState(), tab)).toEqual({
executionHostId: 'runtime:env-1',
runtimeEnvironmentId: 'env-1'
})
expect(mocks.unsubscribe).not.toHaveBeenCalled()
expect(mocks.subscribeCompletions).toHaveBeenCalledOnce()

Expand Down
Loading