Repository navigation
fix(editor): update image insertion test to current arguments - #25330
Closed
brennanb2025 wants to merge 1 commit into
Closed
brennanb2025 wants to merge 1 commit into
brennanb2025 wants to merge 1 commit into
Conversation
This was referenced Oct 5, 2026
Merged
brennanb2025
marked this pull request as ready for review
October 5, 2026 06:13
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Main's typecheck fails since #25176 and #24489 merged: #25176 replaced
insertPoswithgetInsertionRange, then #24489 added a test using the old argument. This updates that test to the current arguments. No user-visible change.What Changed
Supply the same collapsed insertion range used by neighboring tests and remove the obsolete editor cast. Production code is unchanged.
Why
The test must follow the current API; changing production behavior would undo the image clipboard fix.
Linked Issue
Regression from #25176 (
e2460907c33, merged October 4 at 23:39:12 UTC) and #24489 (51fe6f3fbad, merged at 23:55:33 UTC).Visual Proof
N/A — test-only correction.
Testing
What I verified: 35 tests passed across
rich-markdown-image-insert.test.ts,rich-markdown-image-insert-code-block.test.ts,rich-markdown-image-insertion-target.test.ts,rich-markdown-paste-image.test.ts, andrich-markdown-local-image.test.ts; changed-file formatting and lint passed on macOS.rich-markdown-async-image-paste.test.tsandrich-markdown-async-image-table.test.tshave 35 failures, reproduced on unchanged main with the same shared dependencies (12 passed). These are outside this test-only fix.What I didn't verify: local typechecking, app UI, Linux, or Windows. CI is the typecheck authority: static analysis and typecheck passed, including its typecheck step. The separately known Claude evidence-retention type error is handled by #25063; any unrelated
qoder-history-search-downgradefailure is outside this PR.Review
Differences from the common pattern: none introduced; this only follows the existing test argument shape. No lifecycle, ownership, runtime, or UI mechanism changes.
Agent skill upstream boundary
docs/reference/agent-skill-sharing-upstream-boundary.mdand copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.Notes
No dependency, platform, SSH, folder-workspace, or mobile behavior changes. Draft only.
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)