Skip to content

[CI] Reduce CI work by removing low-value tests and duplicate fuzz comparisons - #25791

Merged
nwparker merged 1 commit into
mainfrom
nwparker/slim-low-value-ci-tests-20261006
Oct 6, 2026
Merged

nwparker merged 1 commit into
mainfrom
nwparker/slim-low-value-ci-tests-20261006

Conversation

@nwparker

@nwparker nwparker commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 421 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​127 $\color{#cf222e}{\Huge{\mathbf{−}}}$​20422 $\color{#cf222e}{\Huge{\mathbf{−}}}$​20295
Prod 17 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​59 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1173 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1114

ELI5

PR checks spend time running source inventories and repeated comparisons that add little confidence. Remove those tests so runners spend more of their time checking real behavior.

What Changed

Remove 132 test files, retain five meaningful contracts in two smaller files, and trim duplicate cases in mixed suites. Remove unused snapshots and test scaffolding, then update workflow commands, test selection, documentation, and reliability gates to match. Fix a fish cleanup race, shebang discovery of locally deleted files, and a compiler-output test that counted receipts before the producing compiler finished.

Application behavior and CI job matrices are unchanged. This intentionally retires source-wide grep guards and exhaustive readiness snapshot characterization; related behavior tests do not provide identical static coverage.

Why

Copied inventories, implementation comparisons, source-string assertions, and mock-success smoke tests consume CI capacity while making refactors expensive. Keep independent transcript, real process, recovery, persistence, wire, and ownership tests instead of replacing removed tests with new mirrors.

One matched local runtime cohort improved from 79.2s to 17.6s. Overall PR wall time and queue improvement are not measured yet.

Linked Issue

Related CI work: #25665 and #25760. No new issue.

Visual Proof

N/A — no UI or application behavior change.

Testing

  • I manually tested these changes locally
  • Automated tests updated; low-value tests deliberately removed

On macOS, before rebase: full mobile 9,964 passed; desktop qualification covers 105,612 passes, one expected failure and 514 existing skips. The final desktop invocation had one unchanged fixture race; its corrected 21-test file passed, and the affected case passed three additional invocations. The failed full-run result remains recorded rather than presented as a single green run.

After rebase onto current main: typecheck, integration/transcript checks and reliability-gate validation run again; normal PR CI validates the integrated branch. Windows/WSL opt-in tests remain, without claiming they ran locally.

Review

Independently reviewed deletions, retained coverage, orphan imports, current workflow references, and preservation of historical native evidence. Dashboard commits are excluded from this PR.

Agent skill upstream boundary

  • Not applicable; no upstream skill source or guidance copied.

Notes

Broad deletion diff with one purpose: less low-value test work. SSH, folder workspaces, remote compatibility, and platform behavior stay covered by retained behavioral suites.

Checklist

  • This PR is small and focused — focused test cleanup, but a large deletion diff
  • Explained the change, mechanism, reason, and tradeoff
  • N/A visual proof with reason
  • Self-reviewed correctness, security, and performance
  • Cross-platform and SSH impact considered
  • Complete hosted CI must pass before merge

@nwparker
nwparker requested a review from brennanb2025 as a code owner October 6, 2026 05:23
@nwparker
nwparker merged commit ca4e239 into main Oct 6, 2026
26 checks passed
brennanb2025 added a commit that referenced this pull request Oct 6, 2026
- Takes main's deletion (#25791) of the host startup call-site inventory, its attribution test and
  daemon-protocol-version.test.ts; v42 stays pinned by daemon-foreground-confirmation-protocol and
  the build-contract test, and launch files by daemon-launch-file-protocol.
- #25720's custom-launch-command test plans its prompted launch with this branch's planner, which
  keeps the custom command on the line.
brennanb2025 added a commit that referenced this pull request Oct 6, 2026
…agent-tree-job-object

Main deleted the Claude and Codex location-support tests (#25791) that this
branch had edited; the deletion is kept. The Codex launch-resolution test still
pins that a Windows host without process creation times starts a chat.
leog added a commit to leog/orca that referenced this pull request Oct 6, 2026
…ew-workspace-setup-only

Conflict: upstream removed worktree-activation-surface-caller-wiring.test.ts
(stablyai#25791), which this branch had extended with two callers. Took the deletion.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
hiphapis added a commit to hiphapis/orca that referenced this pull request Oct 7, 2026
Accepted upstream's deletion of config/scripts/orchestration-skill-guidance.test.mjs.
stablyai#25791 removed all four skill-guidance test files as a category with no
replacement, so this branch's assertions go with them; the guidance text they
pinned is unchanged. references/coordinator-loop.md auto-merged cleanly: stablyai#24624
rewrote the OpenCode paragraph in the slot this branch had already placed it,
and the defaults policy around it is intact.

src/cli/bundled-skill-guides.ts is generated and was regenerated, not resolved.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011nnNsG3p4Do9eiyfXGr2rB
@nwparker nwparker changed the title Reduce CI work by removing low-value tests and duplicate fuzz comparisons [CI] Reduce CI work by removing low-value tests and duplicate fuzz comparisons Oct 9, 2026
diegoesolorzano added a commit to diegoesolorzano/orca that referenced this pull request Oct 11, 2026
Integrate ~2007 upstream commits, mostly OpenCode v2 integration maturity
(status reporting per pane stablyai#23722/stablyai#24962, hook install in terminal config
dir stablyai#25296, stop stale plugin from retired shared hooks dir stablyai#23500) plus
@orca/process-host extraction, structured chat over ACP, and many agents.

Fork conflicts resolved (6): minimax/zai catalog entries relocated to the
new split agent-catalog-entries-secondary.ts; redraw shortcut moved to the
new matches() helper; createLocalNestedRepoScanFilesystem updated to
isGitRepoAsync; nestedReposPromise kept after upstream made timing a param;
showNestedReposToast import kept, dead settingsForRepoOwner dropped.
Added minimax/zai to the new Record<TuiAgent> maps (rest-signal, readiness
lane) and switched the Activity wrapper-grouping types to TerminalAgent.
Accepted upstream's deletion of the global-fetch audit test (stablyai#25791).

typecheck clean; git-crypt, time-tracker, activity and shortcut-policy
suites green (2305 tests).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant