Skip to content

test(native-chat): pass the live-turn thinking check its host-turn source (fixes main typecheck) - #25936

Closed
Jinwoo-H wants to merge 1 commit into
mainfrom
fix-live-turn-test-types
Closed

Jinwoo-H wants to merge 1 commit into
mainfrom
fix-live-turn-test-types

Conversation

@Jinwoo-H

@Jinwoo-H Jinwoo-H commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​6 $\color{#cf222e}{\Huge{\mathbf{−}}}$​2 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​4
Prod 0 0 0 0

ELI5

Main fails typecheck. Two PRs that were each green on their own crossed when they merged; this updates two test lines so they match.

What Changed

#19221 added two reasoning-state test cases that call isStructuredAgentSessionThinking([...]) with a bare item list. #25751 changed that function to take { items, latestTurn }. This wraps those two calls in { items: [...] }. Test-only; no product change.

Why

It unblocks typecheck for every open PR. Updating the test is the smallest fix; the function's new signature is the intended one.

Linked Issue

N/A (main breakage).

Visual Proof

N/A: test-only change.

Testing

  • pnpm tc passes (it failed on main).

  • pnpm test src/shared/structured-agent-session-live-turn.test.ts: 17/17 passed.

  • I manually tested these changes locally

  • Automated tests added/updated, or explained why not below

Agent skill upstream boundary

  • Not applicable, or this change follows docs/reference/agent-skill-sharing-upstream-boundary.md and copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.

Checklist

  • This PR is small and focused
  • I explained what changed and why (ELI5, the user-facing before/after, the mechanism, and why over the alternatives)
  • Before/after screenshots or videos attached for UI changes, or N/A with reason
  • Self-reviewed for correctness, security, and performance
  • Cross-platform, SSH/remote, and path/shortcut impact considered (or N/A)
  • pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (or CI will cover; local preferred)

…urce

#19221 added two reasoning-state cases calling isStructuredAgentSessionThinking
with a bare item list, and #25751 changed the function to take { items,
latestTurn }. Each was green alone; together main fails typecheck. Wrap the two
calls in { items }.
@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3a659642-faae-497d-b50f-a5382e5d76a5
📥 Commits

Reviewing files that changed from the base of the PR and between defd85a and 7ed8d2c.

📒 Files selected for processing (1)
  • src/shared/structured-agent-session-live-turn.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The test for isStructuredAgentSessionThinking now passes an { items } object for both running and completed reasoning. The expected results remain true for running reasoning and false for completed reasoning.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 7ed8d

This change updates two test calls to use the predicate’s required { items } input while preserving the expected results. No concrete issue blocks merging.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the test change and its purpose: fixing the live-turn thinking check input shape to resolve a typecheck failure. It is somewhat long but remains specific and relevant.
Description check ✅ Passed The description explains the change, its purpose, and reported test results. It also includes the required visual-proof statement for a test-only change and completes most checklist items. The Linked …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Jinwoo-H

Jinwoo-H commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

No longer needed: main already fixed these calls.

@Jinwoo-H Jinwoo-H closed this Oct 6, 2026
@Jinwoo-H
Jinwoo-H deleted the fix-live-turn-test-types branch October 6, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant