Repository navigation
test(native-chat): pass the live-turn thinking check its host-turn source (fixes main typecheck) - #25936
test(native-chat): pass the live-turn thinking check its host-turn source (fixes main typecheck)#25936Jinwoo-H wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe test for Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to This change updates two test calls to use the predicate’s required 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
No longer needed: main already fixed these calls. |
ELI5
Main fails typecheck. Two PRs that were each green on their own crossed when they merged; this updates two test lines so they match.
What Changed
#19221 added two reasoning-state test cases that call
isStructuredAgentSessionThinking([...])with a bare item list. #25751 changed that function to take{ items, latestTurn }. This wraps those two calls in{ items: [...] }. Test-only; no product change.Why
It unblocks typecheck for every open PR. Updating the test is the smallest fix; the function's new signature is the intended one.
Linked Issue
N/A (main breakage).
Visual Proof
N/A: test-only change.
Testing
pnpm tcpasses (it failed on main).pnpm test src/shared/structured-agent-session-live-turn.test.ts: 17/17 passed.I manually tested these changes locally
Automated tests added/updated, or explained why not below
Agent skill upstream boundary
docs/reference/agent-skill-sharing-upstream-boundary.mdand copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)