Repository navigation
Keep sidebar section collapse independent across execution hosts - #25944
Conversation
318619d to
d72a40d
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (13)
💤 Files with no reviewable changes (3)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe sidebar now scopes collapse keys for pinned and regular worktree sections by execution host. Folder-workspace and worktree reveal logic uses host-qualified keys when host-scoped groups are active. New unit and end-to-end tests cover collapse and reveal behavior across host types and grouping modes. Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to Remote section toggles retain their independent collapse state. No identified issue blocks merging after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ELI5
Revealing a remote workspace should open its section while leaving the local section as you set it.
What Changed
All, workspace-status, and review sections previously reused one saved collapse key across hosts. They now use the host-specific collapse mechanism already used by Pinned. Rows are split by host before applying collapse; clicks, normal Reveal, folder-workspace Reveal, and the send picker use the same section keys. The default combined view keeps its single shared section.
A separate test-only commit repairs a readiness race found by CI on main: the source-control cancellation fixture now publishes its PID after installing its signal handler. Cancellation could previously land between those steps, killing the fixture before it could write its shutdown marker. Production shutdown behavior and the assertions are unchanged.
Why
The cause is shared section ownership, so expanding and then restoring local state would leave clicks and other reveal paths inconsistent. Generalizing the existing Pinned mechanism fixes those paths together and hides every row within a collapsed section, including folder workspaces.
Linked Issue
Internal follow-up to #25836. First behavior PR in the sidebar fix stack; based on main with its CI repairs already merged (#25933 and #25949).
Visual Proof
Workspace-status example: same real Reveal button, selected remote workspace, and initial collapsed sections on both builds. All and review status use the same host-owned section mechanism and have matching rendered regression coverage. Before: local rows expand too. After: only the remote section opens.
Testing
pnpm tc, changed-file lint, and changed-code quality gate passed on the updated main base.Review
Local legacy keys, combined grouping, project/lineage collapse, pinned policy, and row identities are preserved. No wire format, production process control, paths, shortcuts, or styling changed.
Agent skill upstream boundary
Checklist