Repository navigation
test(agent-launch): give the record-store slot test the launch-args resolver #25721 made required - #25971
Closed
brennanb2025 wants to merge 1 commit into
Closed
test(agent-launch): give the record-store slot test the launch-args resolver #25721 made required#25971brennanb2025 wants to merge 1 commit into
brennanb2025 wants to merge 1 commit into
Conversation
…esolver #25721 made required #24934 was squashed after #25721 made resolveLaunchArgs a required structured-runtime dep, and its branch never contained #25721, so its CI could not see that the slot test omits it. Main now fails tc:node (TS2741) and the test fails at runtime (the host refuses to install without the resolver).
Contributor
Author
|
Closing as a duplicate of #25970, which carries the same fix. |
brennanb2025
deleted the
brennanb2025/fix-main-slot-test-resolve-launch-args
branch
October 6, 2026 21:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Main is red: #24934's squash met #25721's new required
resolveLaunchArgsdep, and one test lacks it. This PR adds the one missing line. Nothing in the app changes.What Changed
The problem.
resolveLaunchArgsa required field of the structured agent-session runtime's dependencies. The runtime refuses to install a chat host without it.src/main/runtime/agent-session-record-store-slot.test.ts, which builds a chat host without that field. feat(agent-launch): host-assigned caller identity and a launch record written when the tab exists (unification 1 of 3) #24934's branch never contained fix(native-chat): honor saved agent Command and Arguments #25721, so its own CI was green. Once both were squashed into main, the two collided:tc:nodefails:agent-session-record-store-slot.test.ts(53,57): error TS2741: Property 'resolveLaunchArgs' is missing. "Static analysis and typecheck" therefore fails on every PR checked against main, which also skips their unit shards.For users: nothing changes. This is test-only.
The change: the test passes
resolveLaunchArgs: () => [], the same value other structured-runtime tests use. That's one line.Linked Issue
None. This fixes main.
Visual Proof
N/A: test-only change.
Testing
On origin/main plus this line:
tc-gate pnpm tc:nodepasses.agent-session-record-store-slot.test.ts: 5 passed (1 failed before the change).oxlint is clean.
I manually tested these changes locally
Automated tests added/updated, or explained why not below
AI Disclosure
Review
Agent skill upstream boundary
docs/reference/agent-skill-sharing-upstream-boundary.mdand copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.Notes
Author: @BrennanKB5. Test-only.
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)