Skip to content

test(agent-launch): give the record-store slot test the launch-args resolver #25721 made required - #25971

Closed
brennanb2025 wants to merge 1 commit into
mainfrom
brennanb2025/fix-main-slot-test-resolve-launch-args
Closed

brennanb2025 wants to merge 1 commit into
mainfrom
brennanb2025/fix-main-slot-test-resolve-launch-args

Conversation

@brennanb2025

@brennanb2025 brennanb2025 commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1 0 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1
Prod 0 0 0 0

ELI5

Main is red: #24934's squash met #25721's new required resolveLaunchArgs dep, and one test lacks it. This PR adds the one missing line. Nothing in the app changes.

What Changed

The problem.

For users: nothing changes. This is test-only.

The change: the test passes resolveLaunchArgs: () => [], the same value other structured-runtime tests use. That's one line.

Linked Issue

None. This fixes main.

Visual Proof

N/A: test-only change.

Testing

On origin/main plus this line:

  • tc-gate pnpm tc:node passes.

  • agent-session-record-store-slot.test.ts: 5 passed (1 failed before the change).

  • oxlint is clean.

  • I manually tested these changes locally

  • Automated tests added/updated, or explained why not below

AI Disclosure

Review

Agent skill upstream boundary

  • Not applicable, or this change follows docs/reference/agent-skill-sharing-upstream-boundary.md and copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.

Notes

Author: @BrennanKB5. Test-only.

Checklist

  • This PR is small and focused
  • I explained what changed and why (ELI5, the user-facing before/after, the mechanism, and why over the alternatives)
  • Before/after screenshots or videos attached for UI changes, or N/A with reason
  • Self-reviewed for correctness, security, and performance
  • Cross-platform, SSH/remote, and path/shortcut impact considered (or N/A)
  • pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (or CI will cover; local preferred)

…esolver #25721 made required

#24934 was squashed after #25721 made resolveLaunchArgs a required structured-runtime dep, and its
branch never contained #25721, so its CI could not see that the slot test omits it. Main now fails
tc:node (TS2741) and the test fails at runtime (the host refuses to install without the resolver).
@brennanb2025

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate of #25970, which carries the same fix.

@brennanb2025
brennanb2025 deleted the brennanb2025/fix-main-slot-test-resolve-launch-args branch October 6, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant