Skip to content

fix(test): drop the duplicate resolveLaunchArgs that breaks main's lint - #25997

Merged
Jinwoo-H merged 1 commit into
mainfrom
brennanb2025/main-dup-resolve-launch-args
Oct 6, 2026
Merged

Jinwoo-H merged 1 commit into
mainfrom
brennanb2025/main-dup-resolve-launch-args

Conversation

@brennanb2025

@brennanb2025 brennanb2025 commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 1 0 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1
Prod 0 0 0 0

ELI5

Main's lint check is failing on every pull request. One test file passes the same setting twice, because two pull requests that merged a few minutes apart each added it. This deletes the extra copy.

What Changed

src/main/runtime/structured-agent-session-codex-stopped-send-order.test.ts passed resolveLaunchArgs: () => [] twice in one object:

Each pull request was fine alone. Merged together, the file has a duplicate key, which the lint check rejects ("Duplicate key 'resolveLaunchArgs'").

Because "static analysis and typecheck" fails first, CI then skips the unit tests, e2e and cross-version jobs on every pull request built against main. So those pull requests can't show they're green. This removes the second copy; the two copies were identical, so nothing about the test changes.

There's no change users can see.

Why

It's the smallest change that makes main pass lint again.

Linked Issue

N/A (maintainer fix for a red main).

Visual Proof

N/A: one duplicated line in a test file; nothing a user sees changes.

Testing

  • Checked that the two copies are identical and that exactly one remains.
  • Automated tests: none added; CI's lint and unit jobs on this pull request are the check.

Review

Agent skill upstream boundary

  • Not applicable, or this change follows docs/reference/agent-skill-sharing-upstream-boundary.md and copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.

Notes

No security, platform, SSH, mobile or compatibility impact: test-only.

Checklist

  • This PR is small and focused
  • I explained what changed and why (ELI5, the user-facing before/after, the mechanism, and why over the alternatives)
  • Before/after screenshots or videos attached for UI changes, or N/A with reason
  • Self-reviewed for correctness, security, and performance
  • Cross-platform, SSH/remote, and path/shortcut impact considered (or N/A)
  • pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (or CI will cover; local preferred)

Author: @BrennanKB5

@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: be10055f-60ad-463a-bffe-e38c0ba453f8
📥 Commits

Reviewing files that changed from the base of the PR and between 7bc9ff9 and 8758e83.

📒 Files selected for processing (1)
  • src/main/runtime/structured-agent-session-codex-stopped-send-order.test.ts
💤 Files with no reviewable changes (1)
  • src/main/runtime/structured-agent-session-codex-stopped-send-order.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.


📝 Walkthrough

Walkthrough

The test host configuration no longer contains a duplicate resolveLaunchArgs property. The remaining property is unchanged.

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to 8758e

No merge-blocking risk is identified; the test-only cleanup is ready for normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: removing a duplicate resolveLaunchArgs entry that breaks lint.
Description check ✅ Passed The description covers the required sections and explains the duplicate key, its impact, the focused fix, and testing. It appropriately marks visual proof as not applicable and identifies this as a ma…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Jinwoo-H
Jinwoo-H merged commit 1eeb8f3 into main Oct 6, 2026
8 checks passed
brennanb2025 added a commit that referenced this pull request Oct 6, 2026
…r-stop

Brings main's own fix for the duplicate resolveLaunchArgs key (#25997). No conflicts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants