Repository navigation
fix(test): drop the duplicate resolveLaunchArgs that breaks main's lint - #25997
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe test host configuration no longer contains a duplicate Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to No merge-blocking risk is identified; the test-only cleanup is ready for normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
brennanb2025
added a commit
that referenced
this pull request
Oct 6, 2026
…r-stop Brings main's own fix for the duplicate resolveLaunchArgs key (#25997). No conflicts.
Merged
8 of 9 tasks
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Main's lint check is failing on every pull request. One test file passes the same setting twice, because two pull requests that merged a few minutes apart each added it. This deletes the extra copy.
What Changed
src/main/runtime/structured-agent-session-codex-stopped-send-order.test.tspassedresolveLaunchArgs: () => []twice in one object:Each pull request was fine alone. Merged together, the file has a duplicate key, which the lint check rejects ("Duplicate key 'resolveLaunchArgs'").
Because "static analysis and typecheck" fails first, CI then skips the unit tests, e2e and cross-version jobs on every pull request built against main. So those pull requests can't show they're green. This removes the second copy; the two copies were identical, so nothing about the test changes.
There's no change users can see.
Why
It's the smallest change that makes main pass lint again.
Linked Issue
N/A (maintainer fix for a red main).
Visual Proof
N/A: one duplicated line in a test file; nothing a user sees changes.
Testing
Review
Agent skill upstream boundary
docs/reference/agent-skill-sharing-upstream-boundary.mdand copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.Notes
No security, platform, SSH, mobile or compatibility impact: test-only.
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)Author: @BrennanKB5