Repository navigation
test(vitest): run agent-launch-instant-tab in the SQLite runtime project - #26028
Merged
Merged
Conversation
#25430 added a test that opens a real agent-session record store, but not to the SQLite runtime list, so vitest-sqlite-runtime-boundary fails on main.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe SQLite database runtime test include list now includes Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The change adds the test to its intended runtime group. No concrete merge-blocking risk is established by the available evidence. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 7, 2026
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
A guard test checks that every test that opens a real SQLite database runs in the test group set up for SQLite. #25430 added one such test without listing it, so the guard test fails on
mainand on every PR branched from it.What Changed
Added
src/main/runtime/rpc/methods/agent-launch-instant-tab.test.tstoSQLITE_DATABASE_RUNTIME_INCLUDE. It opens a real record store throughopenTestAgentSessionRecordStore. The list format follows #25998, which fixed three earlier gaps of the same kind.Why
It unblocks red CI on
mainand on open PRs. No product code changes.Testing
pnpm exec vitest run --config config/vitest.config.ts config/scripts/vitest-sqlite-runtime-boundary.test.ts src/main/runtime/rpc/methods/agent-launch-instant-tab.test.ts: fails onmainand passes with this change (47 tests).