Skip to content

test(vitest): run agent-launch-instant-tab in the SQLite runtime project - #26028

Merged
Jinwoo-H merged 1 commit into
mainfrom
fix/sqlite-runtime-list-instant-tab
Oct 7, 2026
Merged

Jinwoo-H merged 1 commit into
mainfrom
fix/sqlite-runtime-list-instant-tab

Conversation

@Jinwoo-H

@Jinwoo-H Jinwoo-H commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 0 0 0 0
Prod 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1 0 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1

ELI5

A guard test checks that every test that opens a real SQLite database runs in the test group set up for SQLite. #25430 added one such test without listing it, so the guard test fails on main and on every PR branched from it.

What Changed

Added src/main/runtime/rpc/methods/agent-launch-instant-tab.test.ts to SQLITE_DATABASE_RUNTIME_INCLUDE. It opens a real record store through openTestAgentSessionRecordStore. The list format follows #25998, which fixed three earlier gaps of the same kind.

Why

It unblocks red CI on main and on open PRs. No product code changes.

Testing

pnpm exec vitest run --config config/vitest.config.ts config/scripts/vitest-sqlite-runtime-boundary.test.ts src/main/runtime/rpc/methods/agent-launch-instant-tab.test.ts: fails on main and passes with this change (47 tests).

  • Automated tests added/updated, or explained why not below

#25430 added a test that opens a real agent-session record store, but not to the
SQLite runtime list, so vitest-sqlite-runtime-boundary fails on main.
@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 494316bf-bc52-44bb-8d4a-dd42760f94aa
📥 Commits

Reviewing files that changed from the base of the PR and between 0c96550 and 7e311bd.

📒 Files selected for processing (1)
  • config/scripts/vitest-sqlite-database-runtime-files.mjs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The SQLite database runtime test include list now includes agent-launch-instant-tab.test.ts.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 7e311

The change adds the test to its intended runtime group. No concrete merge-blocking risk is established by the available evidence.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the change: adding the test to the SQLite runtime project.
Description check ✅ Passed The description explains the change, reason, and reported test result. It does not include a linked issue or the template’s Visual Proof section with an N/A explanation, but the core description is co…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant