Skip to content

fix(ci): run the agent-launch instant-tab test in the Node runtime project - #26030

Closed
Jinwoo-H wants to merge 1 commit into
mainfrom
fix/agent-launch-instant-tab-node-runtime
Closed

Jinwoo-H wants to merge 1 commit into
mainfrom
fix/agent-launch-instant-tab-node-runtime

Conversation

@Jinwoo-H

@Jinwoo-H Jinwoo-H commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 0 0 0 0
Prod 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1 0 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1

ELI5

Main's unit tests are red. #25430 added agent-launch-instant-tab.test.ts, which opens a real SQLite database, but did not list it in the Node runtime project. The guard test vitest-sqlite-runtime-boundary.test.ts fails on every PR until it is listed.

What Changed

CI config only: adds the file to SQLITE_RUNTIME_INCLUDE in config/scripts/vitest-sqlite-runtime-files.mjs, next to its agent-launch-* siblings (same fix shape as #26010).

Why

Smallest change that restores a green main; no product code changes.

Linked Issue

N/A — main-breakage fix after #25430.

Visual Proof

N/A — CI config only.

Testing

  • vitest run config/scripts/vitest-sqlite-runtime-boundary.test.ts fails on main, passes with this change; the instant-tab test passes in the Node project.

  • config/scripts vitest/runtime-boundary suites: 13 files pass.

  • I manually tested these changes locally

  • Automated tests added/updated, or explained why not below

@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6a1f03a4-4f83-4705-83b9-6c9941716c4d
📥 Commits

Reviewing files that changed from the base of the PR and between 0c96550 and dbc23f9.

📒 Files selected for processing (1)
  • config/scripts/vitest-sqlite-runtime-files.mjs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The SQLite runtime include list now includes agent-launch-instant-tab.test.ts.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to dbc23

No actionable regression is evident from this test-fixture inclusion; merge after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: adding the instant-tab test to the Node runtime project. It is specific and concise.
Description check ✅ Passed The description covers the change, reason, visual-proof status, and reported testing. It marks the linked issue as N/A; if the author is an outside contributor, the template requires an actual issue l…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Jinwoo-H Jinwoo-H closed this Oct 7, 2026
@Jinwoo-H
Jinwoo-H deleted the fix/agent-launch-instant-tab-node-runtime branch October 7, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant