Repository navigation
fix(lint): bring structured-agent-session-host back under max-lines - #26050
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe subscribe property no longer declares an explicit return type. Its return type is inferred from backgroundTasks.subscribe. Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to This is a type-annotation change only; the subscribe return contract is preserved. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the lint failure, the type inference change, and the reported verification. It omits the required linked issue and does not include the template’s Visual Proof section, which should state N/A with a reason for this non-UI change.
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Main fails the Lint step for every PR: #25986 added one line to
structured-agent-session-host.ts, putting it at 301 counted lines against the 300max-lineslimit.This change folds
subscribeonto one line by dropping its explicit return type. The inferred type is the same (Promise<() => void>), so behavior does not change.Verification
oxlinton the file: cleantsc -p config/tsconfig.node.json: clean