Skip to content

fix(lint): bring structured-agent-session-host back under max-lines - #26050

Merged
Jinwoo-H merged 1 commit into
mainfrom
fix/structured-host-max-lines
Oct 7, 2026
Merged

Jinwoo-H merged 1 commit into
mainfrom
fix/structured-host-max-lines

Conversation

@Jinwoo-H

@Jinwoo-H Jinwoo-H commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 0 0 0 0
Prod 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1 $\color{#cf222e}{\Huge{\mathbf{−}}}$​2 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1

Summary

Main fails the Lint step for every PR: #25986 added one line to structured-agent-session-host.ts, putting it at 301 counted lines against the 300 max-lines limit.

This change folds subscribe onto one line by dropping its explicit return type. The inferred type is the same (Promise<() => void>), so behavior does not change.

Verification

  • oxlint on the file: clean
  • tsc -p config/tsconfig.node.json: clean

@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 631df7c2-adef-4f6f-aa6e-c9e3b5606a38
📥 Commits

Reviewing files that changed from the base of the PR and between 70c6876 and 1a5f687.

📒 Files selected for processing (1)
  • src/main/native-chat/agent-session-wire/structured-agent-session-host.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The subscribe property no longer declares an explicit return type. Its return type is inferred from backgroundTasks.subscribe.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 1a5f6

This is a type-annotation change only; the subscribe return contract is preserved. No merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the lint failure, the type inference change, and the reported verification. It omits the required linked issue and does not include the template’s Visual Proof section, which … Add the linked issue in the Fixes section. Add a Visual Proof section with “N/A” and a brief reason. Include the relevant Testing checklist items or explain why they do not apply.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the lint issue and the file-level change that resolves it.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the lint failure, the type inference change, and the reported verification. It omits the required linked issue and does not include the template’s Visual Proof section, which should state N/A with a reason for this non-UI change.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant