Skip to content

fix(native-chat): split the attachment failure words out so Lint passes on main #26079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nwparker merged 1 commit into from
Oct 7, 2026
Merged

fix(native-chat): split the attachment failure words out so Lint passes on main #26079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions src/renderer/src/components/native-chat/agent-session-failure-attachment-words-text.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
// Desktop words for the attachment refusals, kept beside the other failure pieces' translations.

import { translate } from '@/i18n/i18n'
import {
AGENT_SESSION_FAILURE_COPY as COPY,
type AgentSessionFailureCopyId,
type AgentSessionFailureCopyValues
} from '../../../../shared/agent-session-failure-copy'

export const ATTACHMENT_FAILURE_PIECES = {
attachmentEmpty: () =>
translate('components.native-chat.failureWords.attachmentEmpty', COPY.attachmentEmpty),
attachmentTooLarge: () =>
translate('components.native-chat.failureWords.attachmentTooLarge', COPY.attachmentTooLarge),
attachmentLargerThan: (values) =>
translate(
'components.native-chat.failureWords.attachmentLargerThan',
COPY.attachmentLargerThan,
values
),
attachmentTooMany: () =>
translate('components.native-chat.failureWords.attachmentTooMany', COPY.attachmentTooMany),
attachmentAtMost: (values) =>
translate(
'components.native-chat.failureWords.attachmentAtMost',
COPY.attachmentAtMost,
values
),
attachmentTotalTooLarge: () =>
translate(
'components.native-chat.failureWords.attachmentTotalTooLarge',
COPY.attachmentTotalTooLarge
),
attachmentTotalMoreThan: (values) =>
translate(
'components.native-chat.failureWords.attachmentTotalMoreThan',
COPY.attachmentTotalMoreThan,
values
),
attachmentUnsupportedType: (values) =>
translate(
'components.native-chat.failureWords.attachmentUnsupportedType',
COPY.attachmentUnsupportedType,
values
),
attachmentNotAFile: () =>
translate('components.native-chat.failureWords.attachmentNotAFile', COPY.attachmentNotAFile),
attachmentNoSource: () =>
translate('components.native-chat.failureWords.attachmentNoSource', COPY.attachmentNoSource),
attachmentInvalid: () =>
translate('components.native-chat.failureWords.attachmentInvalid', COPY.attachmentInvalid),
attachmentUnreadable: () =>
translate('components.native-chat.failureWords.attachmentUnreadable', COPY.attachmentUnreadable)
} satisfies Partial<
Record<AgentSessionFailureCopyId, (values: AgentSessionFailureCopyValues) => string>
>
48 changes: 2 additions & 46 deletions src/renderer/src/components/native-chat/agent-session-failure-words-text.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
type AgentSessionFailureCopyValues,
type AgentSessionFailureSay
} from '../../../../shared/agent-session-failure-copy'
import { ATTACHMENT_FAILURE_PIECES } from './agent-session-failure-attachment-words-text'

// The pieces a refusal notice says too keep the notice's keys, so each has one translation.
const PIECES: Record<AgentSessionFailureCopyId, (values: AgentSessionFailureCopyValues) => string> =
Expand Down Expand Up @@ -155,52 +156,7 @@ const PIECES: Record<AgentSessionFailureCopyId, (values: AgentSessionFailureCopy
COPY.providerRejectedQuoted,
values
),
attachmentEmpty: () =>
translate('components.native-chat.failureWords.attachmentEmpty', COPY.attachmentEmpty),
attachmentTooLarge: () =>
translate('components.native-chat.failureWords.attachmentTooLarge', COPY.attachmentTooLarge),
attachmentLargerThan: (values) =>
translate(
'components.native-chat.failureWords.attachmentLargerThan',
COPY.attachmentLargerThan,
values
),
attachmentTooMany: () =>
translate('components.native-chat.failureWords.attachmentTooMany', COPY.attachmentTooMany),
attachmentAtMost: (values) =>
translate(
'components.native-chat.failureWords.attachmentAtMost',
COPY.attachmentAtMost,
values
),
attachmentTotalTooLarge: () =>
translate(
'components.native-chat.failureWords.attachmentTotalTooLarge',
COPY.attachmentTotalTooLarge
),
attachmentTotalMoreThan: (values) =>
translate(
'components.native-chat.failureWords.attachmentTotalMoreThan',
COPY.attachmentTotalMoreThan,
values
),
attachmentUnsupportedType: (values) =>
translate(
'components.native-chat.failureWords.attachmentUnsupportedType',
COPY.attachmentUnsupportedType,
values
),
attachmentNotAFile: () =>
translate('components.native-chat.failureWords.attachmentNotAFile', COPY.attachmentNotAFile),
attachmentNoSource: () =>
translate('components.native-chat.failureWords.attachmentNoSource', COPY.attachmentNoSource),
attachmentInvalid: () =>
translate('components.native-chat.failureWords.attachmentInvalid', COPY.attachmentInvalid),
attachmentUnreadable: () =>
translate(
'components.native-chat.failureWords.attachmentUnreadable',
COPY.attachmentUnreadable
),
...ATTACHMENT_FAILURE_PIECES,
emptyMessage: () =>
translate('components.native-chat.failureWords.emptyMessage', COPY.emptyMessage),
queueFull: () => translate('components.native-chat.failureWords.queueFull', COPY.queueFull),
Expand Down
Loading