Repository navigation
Keep open Remote Settings in sync with saved servers - #26581
Conversation
236fb1a to
86b0969
Compare
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to Saved-server additions and removals refresh the store-backed catalog, which reflects store updates. No actionable merge-blocking risk is evident in the reviewed changes. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)✅ Passed checks (4 passed)✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
86b0969 to
3c43129
Compare
ELI5
An open Settings page kept saying there were no saved servers after Orca successfully connected a new SSH host. It now shows the connected server immediately, including its management controls.
What Changed
Remote Settings reads the existing shared saved-server catalog instead of keeping a separate copy from its first request. Additions, renames, and removals now appear while the page stays open. Initial and manual refreshes still publish through the existing store, and recipe-created VM servers remain filtered out.
Rebased onto main (Phase 3/3.5). The Docker SSH end-to-end spec and its CI-lane routing were dropped to keep this a product-only change; the unit tests cover the mechanism.
Why
SSH conversion already publishes the new server to the shared catalog, but Settings never subscribed to it. Reading that catalog removes the stale copy without adding polling or repeated host probes. The existing rows continue using the host-status store for reachability.
Linked Issue
Found while validating #26483. Independent fix against
OrcaWin/phase35; no dependency on the other consolidation fixes.Visual Proof
Before: after successful managed connection, the shared catalog contains the server but Settings still says “No saved servers.”
After: the same flow displays the connected server and its Stop control without reopening Settings.
Baseline failure: settings-live-catalog-runtime-red.log
Corrected run: settings-live-catalog-runtime-green.log
Testing
Hidden macOS Electron client and a real Linux Docker SSH host using the exact installed
1.4.223-adhoc.20261008080519server template. Baseline fails; corrected flow passes in 8.0 seconds. No Windows runtime claim.124 tests across 10 files pass, including saved-server additions/renames/removals during an unavailable-host probe, VM filtering, existing host-status behavior, and CI routing. Full
pnpm tc,pnpm lint, changed-code quality, fresh Electron E2E build, and commit hooks pass.Review
The product change replaces one local state value with a subscription and filtered derived list. No new timers, transport calls, wire fields, or style changes.
Agent skill upstream boundary
Notes
The change applies to the shared catalog for local and SSH-managed servers and makes no assumptions about repository versus folder workspaces. Contact loss continues to use the existing host-status verdicts.
Checklist