[nwparker]

	Files	Added	Deleted	Net
Test	1	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​29	$\color{#cf222e}{\Huge{\mathbf{−}}}$​1	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​28
Prod	7	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​12	0	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​12

ELI5

Stopping the selected Active Server was safely refused, but Settings told users to close running terminals even when the host had none. It now tells them to choose another Active Server in Advanced first.

What Changed

The existing localized outcome formatter handles orcad_stop_active_environment before the general live-terminal verdict. All six supported language catalogs include the instruction. Running-terminal and unverifiable refusals retain their existing wording.

Rebased onto main (Phase 3/3.5). The Docker SSH end-to-end spec and its CI-lane routing were dropped to keep this a product-only change; the unit tests cover the mechanism.

Why

The main process already provides a specific refusal code, but the UI grouped every live verdict under running terminals. Matching that code gives users the useful next step without changing stop policy, displaying raw backend text, or changing the verdict contract.

Linked Issue

Found while validating #26483. Independent fix against OrcaWin/phase35.

Visual Proof

Before: selected host and “Running terminals: 0” remain visible while Stop tells the user to close terminals.

After: Stop explains how to change the Active Server; the host remains available.

Baseline failure: active-server-stop-copy-runtime-red.log

Corrected run: active-server-stop-copy-runtime-green.log

Testing

• I manually tested these changes locally
• Automated tests added/updated

Hidden macOS Electron client + real Linux Docker SSH host using the exact installed 1.4.223-adhoc.20261008080519 server template. Baseline fails; corrected UI flow passes in 13.1 seconds. No Windows runtime claim.

77 tests across six files pass, including the existing main-process active-server guard, refusal wording, and CI routing. Full pnpm tc, pnpm lint (including localization checks), changed-code quality, fresh Electron E2E build, and commit hooks pass.

Review

Six product-code lines add the specific localized outcome. The host’s stop guard and process handling are unchanged.

Agent skill upstream boundary

• Not applicable; no upstream skill-installer content copied.

Notes

No new transport calls, wire fields, timers, style changes, or platform-specific behavior. The fix uses an existing code and applies equally to repository and folder workspaces. Contact loss stays unverifiable.

Checklist

• This PR is small and focused
• Explained before/after, mechanism, and why
• Before/after screenshots and real runtime logs attached
• Self-reviewed for correctness, security, and performance
• Cross-platform, SSH, folder workspace, and compatibility impact considered
• Local tests, typecheck, lint, quality, localization, and build pass

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 295103d4-104f-4d05-96f8-51a4cc0aa993

📥 Commits

Reviewing files that changed from the base of the PR and between 87eb8a7 and af2c326.

📒 Files selected for processing (6)

• src/renderer/src/i18n/locales/en.json
• src/renderer/src/i18n/locales/es.json
• src/renderer/src/i18n/locales/fr.json
• src/renderer/src/i18n/locales/ja.json
• src/renderer/src/i18n/locales/ko.json
• src/renderer/src/i18n/locales/zh.json

🚧 Files skipped from review as they are similar to previous changes (6)

• src/renderer/src/i18n/locales/en.json
• src/renderer/src/i18n/locales/zh.json
• src/renderer/src/i18n/locales/fr.json
• src/renderer/src/i18n/locales/ja.json
• src/renderer/src/i18n/locales/es.json
• src/renderer/src/i18n/locales/ko.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

---

📝 Walkthrough

Walkthrough

The managed-server outcome label now gives an instruction when a stop is refused because the server is active. Tests cover this refusal and running-terminal and unverifiable-census outcomes. English, Spanish, French, Japanese, Korean, and Chinese locale files add translations for the active-server message.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to af2c3

The active-server refusal now gives users the intended instruction without changing the other refusal messages. No issue identified here needs resolution before merge.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check		The title clearly identifies the main change: explaining the Active Server stop refusal in Settings.
Description check		The description is complete and focused. It includes the user impact, implementation details, rationale, linked issue reference, visual proof, testing evidence, review notes, compatibility considerati…
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (6 skipped: 6 …
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}