Repository navigation
Await Git checks while discovering and importing nested projects - #26790
Merged
nwparker merged 19 commits intoOct 10, 2026
Merged
Conversation
Share repository discovery decisions across synchronous compatibility callers and the existing asynchronous Git runner. Await discovery in project registration, nested imports, and folder upgrades, and recheck folder ownership after discovery completes.
…pc-audit-local-1008
…to nwparker/win-issues-ipc-audit-local-1008
This was referenced Oct 9, 2026
…pc-audit-local-1008
…/nested-repository-detection-async-task1cc89eeb
…/nested-repository-detection-async-task1cc89eeb
nwparker
changed the base branch from
nwparker/win-issues-ipc-audit-local-1008
to
main
October 10, 2026 09:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Opening a folder containing Git projects keeps Orca responsive while it checks those repositories.
What Changed
Nested-project discovery and local/paired import await the shared async classifier from #26760. Existing scan limits, selection rules, host routing and return shapes stay in place. This PR changes three files; it does not add a second scanner or classifier.
Why
The existing flows were already asynchronous, so awaiting the shared runner removes their blocking Git calls with minimal code. #26760 supplies the classifier and host behavior.
Linked Issue
Related to #20497. Based on #26760; merge it first. #26791 can merge independently afterward.
Visual Proof
N/A — no layout change. Fresh hidden Electron tests exercise both Add Project import dialogs, including a small selection from a large nested folder.
Testing
Final head
7333728f9847e181d21510a62ed1e5ae06bd90ae, base #26760 at1fdc56bf558c.pnpm tcand changed-code quality pass.18159658119f1000e339200feaa8b3ad49f028e4matches the expected manifest and builds successfully; four shipped registration/folder tests and two classifier/routing checks pass. Windows nested-import UI is not claimed.Review
Low incremental code merge risk: three existing callers await the same classifier, without new scan policy or wire fields. Shared synchronous metadata fallback remains a limit; real SSH import-dialog/disconnect races are not claimed. The first CI run passed every assertion but failed two jobs on unhandled React callbacks after browser-environment teardown (
window is not defined). The renderer tree and dependencies are identical to the passing core/folder heads. Independent review found missing explicit hook cleanup in those unchanged tests with Vitest globals disabled; a queued React callback surviving teardown is plausible. One bounded 31-test comparison passed on both baseline and final source without reproducing the error (Node/macOS, unlike Linux/Bun CI). Final-head CI is green after one rerun of the failed jobs (run 38037729350, attempt 2); the initial failures remain part of the record. No source change or repeated reruns were used to seek green. Windows packaging passes. The auxiliary Windows fixture later reported lockfile drift; its diff was unavailable, so exact post-install dependency reproducibility is unverified.Agent skill upstream boundary
Checklist