Skip to content

Await Git checks while discovering and importing nested projects - #26790

Merged
nwparker merged 19 commits into
mainfrom
nwparker/nested-repository-detection-async-task1cc89eeb
Oct 10, 2026
Merged

nwparker merged 19 commits into
mainfrom
nwparker/nested-repository-detection-async-task1cc89eeb

Conversation

@nwparker

@nwparker nwparker commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 0 0 0 0
Prod 3 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​8 $\color{#cf222e}{\Huge{\mathbf{−}}}$​7 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1

ELI5

Opening a folder containing Git projects keeps Orca responsive while it checks those repositories.

What Changed

Nested-project discovery and local/paired import await the shared async classifier from #26760. Existing scan limits, selection rules, host routing and return shapes stay in place. This PR changes three files; it does not add a second scanner or classifier.

Why

The existing flows were already asynchronous, so awaiting the shared runner removes their blocking Git calls with minimal code. #26760 supplies the classifier and host behavior.

Linked Issue

Related to #20497. Based on #26760; merge it first. #26791 can merge independently afterward.

Visual Proof

N/A — no layout change. Fresh hidden Electron tests exercise both Add Project import dialogs, including a small selection from a large nested folder.

Testing

Final head 7333728f9847e181d21510a62ed1e5ae06bd90ae, base #26760 at 1fdc56bf558c.

  • 102 discovery/import tests pass, including bounded traversal and queued discovery.
  • Both real nested-import dialog flows pass on a freshly built macOS hidden app.
  • Full pnpm tc and changed-code quality pass.
  • Fresh Windows combined validation merge 18159658119f1000e339200feaa8b3ad49f028e4 matches the expected manifest and builds successfully; four shipped registration/folder tests and two classifier/routing checks pass. Windows nested-import UI is not claimed.
  • Hidden UI flows manually exercised
  • Existing tests cover the shared classifier and import behavior

Review

Low incremental code merge risk: three existing callers await the same classifier, without new scan policy or wire fields. Shared synchronous metadata fallback remains a limit; real SSH import-dialog/disconnect races are not claimed. The first CI run passed every assertion but failed two jobs on unhandled React callbacks after browser-environment teardown (window is not defined). The renderer tree and dependencies are identical to the passing core/folder heads. Independent review found missing explicit hook cleanup in those unchanged tests with Vitest globals disabled; a queued React callback surviving teardown is plausible. One bounded 31-test comparison passed on both baseline and final source without reproducing the error (Node/macOS, unlike Linux/Bun CI). Final-head CI is green after one rerun of the failed jobs (run 38037729350, attempt 2); the initial failures remain part of the record. No source change or repeated reruns were used to seek green. Windows packaging passes. The auxiliary Windows fixture later reported lockfile drift; its diff was unavailable, so exact post-install dependency reproducibility is unverified.

Agent skill upstream boundary

  • Not applicable; no upstream skill-installer source copied.

Checklist

  • Focused scope, mechanism and alternatives explained
  • Cross-platform, SSH, folder and wire compatibility considered
  • Focused tests, full typecheck, changed quality and fresh builds pass

@nwparker
nwparker changed the base branch from nwparker/win-issues-ipc-audit-local-1008 to main October 10, 2026 09:01
@nwparker
nwparker merged commit 803ab30 into main Oct 10, 2026
50 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant