Skip to content

test(e2e): keep two host sections in the catalog-retry reconnect test - #26838

Merged
OrcaWin merged 1 commit into
mainfrom
np/fix-autoconvert-e2e
Oct 9, 2026
Merged

OrcaWin merged 1 commit into
mainfrom
np/fix-autoconvert-e2e

Conversation

@OrcaWin

@OrcaWin OrcaWin commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator
Files Added Deleted Net
Test 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​5 $\color{#cf222e}{\Huge{\mathbf{−}}}$​2 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​3
Prod 0 0 0 0

ELI5

One of the SSH end-to-end tests on main started failing on every pull request. The test was waiting for a sidebar heading that the app correctly stops showing. This PR gives the test the setup it needs to see that heading again, and leaves the app unchanged.

What Changed

The test "reconnect restores the managed host name after its conversion catalog fails" checks that, after the managed-server list briefly fails to load and then recovers, the sidebar heading for the converted SSH host shows the host's real name.

The sidebar only shows host headings when workspaces are split across at least two hosts. A single host section is hidden on purpose. In this test, both seeded workspaces (a project and a folder) live on the one SSH host.

  • Before this PR: after Keep migrated folder workspaces under their Remote host #26535 fixed which section a migrated folder belongs to, both workspaces landed in the one managed-host section. The heading was correctly hidden, so the test found 0 headings and failed.
  • After this PR: the test adds a local project before it seeds the SSH profile. That puts workspaces on two hosts, so the managed host's heading renders, and the test still checks that the heading shows the host's real name.

Why

The test came from #26531, which branched before #26535 landed. On that older base, a migrated folder was wrongly kept under its old SSH host, so the folder and the project split into two host sections by accident, and that is the only reason the heading appeared. #26535 fixed that bug, and its sibling test (a relay-era profile converts its SSH host...) added a local project at the same point for the same reason. This PR uses the same setup. It adds no waits, and the assertions stay as strict as before: the folder row must keep its managed host identity, and the heading must show the recovered host name.

The other option was to change the product so a single host section still shows its heading. That would bring back the clutter the "lone section is hidden" rule exists to prevent, so I rejected it.

Linked Issue

N/A (maintainer fix for main CI)

Visual Proof

N/A: test-only change. CI failure screenshot from main showed the project and the folder grouped together with no host heading.

Testing

  • Automated tests added/updated (the e2e job ssh host auto-converts to managed orcad (Docker) runs this spec)
  • oxlint, check:code-quality:changed, audit:anti-slop and pnpm tc pass locally

Review

Agent skill upstream boundary

  • Not applicable, or this change copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.

Notes

Test-only. No impact on platforms, SSH behavior, or compatibility.

Checklist

  • This PR is small and focused
  • I explained what changed and why (ELI5, the user-facing before/after, the mechanism, and why over the alternatives)
  • Before/after screenshots or videos attached for UI changes, or N/A with reason
  • Self-reviewed for correctness, security, and performance
  • Cross-platform, SSH/remote, and path/shortcut impact considered (or N/A)
  • pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (or CI will cover; local preferred)

@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5c0fa9ff-72a9-497e-99ee-c459fcf4e167

📥 Commits

Reviewing files that changed from the base of the PR and between 7b1242b and bf493bc.


📒 Files selected for processing (1)
  • tests/e2e/ssh-orcad-auto-convert.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.



📝 Walkthrough

Walkthrough

The catalog-failure reconnection test now requests the testRepoPath fixture. After the first app launch is ready, it adds the repository as a local repository before closing the app and seeding the relay-era profile. The test continues to inject a runtime-environment catalog failure during migration and verify reconnection and managed-host display after restoring the handler.


Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to bf493

This test-only change supplies the second host context while retaining the catalog-failure and reconnect checks. No actionable merge risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check Passed The title clearly identifies the focused change: preserving two host sections in the catalog-retry reconnect end-to-end test.
Description check Passed The description is complete and specific. It explains the failure, the test setup change, the reason for the change, testing coverage, and why no product change is needed. The N/A linked issue and vis…
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@OrcaWin
OrcaWin merged commit 049bf80 into main Oct 9, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant