Repository navigation
Fix roadmap crash with plugin language packs - #26860
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughProjectRoadmap now gets its formatting locale through getIntlLocale(). Tests cover the pt-BR locale and an unsupported locale that falls back to DEFAULT_LOCALE. They verify the plugin resource-language identifier, localized month ticks, and scheduled-bar date-range labels. Test cleanup resets plugin language packs and restores the default renderer UI language. Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The roadmap page now formats dates with a supported locale, which fixes the crash with plugin language packs. No merge-blocking risk was identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ELI5
Opening a GitHub Project roadmap with a community language pack could crash the Tasks page. Date labels now use the pack's real locale.
What Changed
The roadmap passed the app's internal translation resource name to the browser's date formatter. Plugin packs use a synthetic name that the formatter rejects. It now calls the existing
getIntlLocale()resolver, which returns the pack's supported locale or the existing English fallback. Calendar placement and dates remain unchanged.Why
This makes roadmap dates follow the same language rule as Orca's other date labels and preserves the user's selected pack locale. A hardcoded fallback would lose that choice. Credit to @OrcaWin for reporting the captured Windows crash and identifying this call site in #25021; this replacement uses focused rendered regressions.
Linked Issue
No dedicated GitHub issue exists for the crash reported in #25021. Related #12533 validates declared plugin locale tags and is a separate PR.
Visual Proof
Both screenshots come from the same hidden Electron renderer fixture using production language-provider, error-boundary and roadmap components with local table data.
Before: selecting the captured Portuguese pack reaches the Tasks error boundary.
After: the roadmap renders Portuguese month labels and date ranges.
Testing
Baseline render: 2 plugin failures, 11 existing tests passing. Fixed: 44 tests pass across roadmap rendering, locale resolution and calendar geometry. All project typechecks, scoped lint/format, changed-files quality checks and the production renderer build/boot-graph gate pass. The same 44 focused tests also pass on native Windows (Node 24.18.0) and Linux (Node 26.8.1). Hidden Electron proof was captured on macOS; live GitHub/SSH and native Windows/Linux Electron UI remain untested. Full CI passed all five unit shards, relay integration, static/typecheck and both packaging jobs. The ready-event run verified identical-check reuse, evaluated UI/server routing and passed aggregate verification.
Review
Independent adversarial source/test review is clean. Checked active versus resolved language, plugin registration and runtime switching, localized ticks and bar ranges, fallback, UTC placement and bounded formatter caches.
Agent skill upstream boundary
Notes
Renderer formatting only. No stored settings, remote messages, credentials, host ownership, platform paths or keyboard behavior change. One existing locale lookup is performed per roadmap render.
Checklist