Skip to content

fix(native-chat): line Continue up with the chat column #27042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brennanb2025 wants to merge 1 commit into
base: main
Choose a base branch
from
+31 −20
Open

fix(native-chat): line Continue up with the chat column #27042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/renderer/src/components/native-chat/NativeChatInterruptedContinue.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,15 @@ describe('Continue on a reply an Orca stop cut off', () => {
)
})

it('sits in the chat column, so it lines up with the transcript and the message box', () => {
render(<Harness />)
expect(continueButton()!.parentElement).toHaveClass(
'mx-auto',
'w-full',
'max-w-(--chat-content-max-width)'
)
})

it('is not offered by a host without the operation; the user continues by sending', () => {
mocks.capability = 'unsupported'
render(<Harness />)
Expand Down
42 changes: 22 additions & 20 deletions src/renderer/src/components/native-chat/NativeChatInterruptedContinue.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,27 +117,29 @@ export function NativeChatInterruptedContinue({
'Continue, and the agent first checks whether its last step finished.'
)
return (
<div className="mx-auto flex w-full max-w-4xl items-center justify-end px-4 py-1">
<Tooltip>
<TooltipTrigger asChild>
<Button
type="button"
variant="ghost"
size="xs"
aria-describedby={explanationId}
onClick={continuation.continueNow}
>
<Play className="size-3" />
{translate('components.native-chat.interruptedContinue.continue', 'Continue')}
</Button>
</TooltipTrigger>
<TooltipContent side="top" sideOffset={4}>
<div className="px-3 py-1 sm:px-4">
<div className="mx-auto flex w-full max-w-(--chat-content-max-width) items-center justify-end">
<Tooltip>
<TooltipTrigger asChild>
<Button
type="button"
variant="ghost"
size="xs"
aria-describedby={explanationId}
onClick={continuation.continueNow}
>
<Play className="size-3" />
{translate('components.native-chat.interruptedContinue.continue', 'Continue')}
</Button>
</TooltipTrigger>
<TooltipContent side="top" sideOffset={4}>
{explanation}
</TooltipContent>
</Tooltip>
<span id={explanationId} className="sr-only">
{explanation}
</TooltipContent>
</Tooltip>
<span id={explanationId} className="sr-only">
{explanation}
</span>
</span>
</div>
</div>
)
}
Loading