Repository navigation
Revert "+" new-tab agent launches to the window route (reverts #26489) - #27173
Merged
Merged
Conversation
#26489 started no-prompt "+" launches through the host lane that is built for terminals no window shows, into a pane the window already owns. That lane differs from the window lane in start size, env, telemetry, failure handling and Windows runtime resolution. Restore main's window route until the two terminal lanes are converged, then move "+" onto the single lane. This reverts commit 7634bbf.
7 of 9 tasks
Contributor
Author
|
Status: ready for review.
|
brennanb2025
marked this pull request as ready for review
October 11, 2026 21:13
brennanb2025
added a commit
that referenced
this pull request
Oct 11, 2026
#27173) #26489 started no-prompt "+" launches through the host lane that is built for terminals no window shows, into a pane the window already owns. That lane differs from the window lane in start size, env, telemetry, failure handling and Windows runtime resolution. Restore main's window route until the two terminal lanes are converged, then move "+" onto the single lane. This reverts commit 7634bbf. (cherry picked from commit 0545841)
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#26489 started "+" agent launches with no prompt through the host's
agent.launch. That covered the "+" menu, Quick Launch, the floating panel's "+" and shortcut, the new-agent shortcut and the dashboard. The goal was strict parity with main. Review after merge found that the host starts those agents through the terminal path built for terminals no window is showing, into a tab the window had already opened. That path differs from the window's own path in ways a user can hit:agent_erroranalytics event.Fixing these one by one in the window (#27077) would have patched the symptoms. The cause is that Orca has two separate terminal-start paths. A plan to merge them into one is being reviewed now, and it moves these launches onto the single path properly.
What this changes for you
These launches go back to exactly how they worked before #26489, which is main's long-standing window launch. Nothing else changes. The "… with AI" buttons and every other launch are untouched.
How
git revert 7634bbfffe0(#26489). It applies cleanly to current main: 13 files, +18 / −305.Verified
tc-gate pnpm tc:webpasses.launch-dashboard-agent.test.ts,FloatingTerminalWindowControls.test.tsx,agent-launch-through-host.test.ts.orca-ci-checks --no-typecheckpasses, 23/23.Author: @BrennanKB5